From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A7D811FF185 for ; Mon, 7 Jul 2025 09:08:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57FDC1BCFB; Mon, 7 Jul 2025 09:09:05 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 07 Jul 2025 09:09:02 +0200 Message-Id: From: "Shan Shaji" To: "Dominik Csapak" , "Proxmox VE development discussion" X-Mailer: aerc 0.14.0 References: <20250703111939.52692-1-s.shaji@proxmox.com> <7de107d7-c2fe-4f22-976d-295cd9263a0c@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.269 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: settings: add privacy policy url link in settings screen X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thank you Dominik, Will keep that in mind. I have created a new patch by including the changes that you mentioned. superseeded by v2: https://lore.proxmox.com/pve-devel/20250704152654.21221-1-s.shaji@proxmox.com/T/#t On Mon Jul 7, 2025 at 8:28 AM CEST, Dominik Csapak wrote: > On 7/4/25 16:40, Shan Shaji wrote: > > On Thu Jul 3, 2025 at 4:00 PM CEST, Dominik Csapak wrote: > >>> + backgroundColor: Theme.of(context).colorScheme.surfaceContainer, > >> > >> this change seems to be unrelated? > > This was intended. The change was made to match the backgroundColor of > > `ProxmoxLoginSelector`. Previously it was using the default scaffold > > backgroundColor. > > ok. In this case it was not really clear why it was done in this patch, so a short > sentence that this is changed too wouldn't hurt IMHO. Also this change is not included in the new patch. I have removed it. > >> > >>> appBar: AppBar( > >>> title: const Text('Settings'), > >>> ), > >>> @@ -45,6 +51,32 @@ class _ProxmoxGeneralSettingsFormState > >>> ProxmoxGeneralSettingsModel.fromLocalStorage(); > >>> }); > >>> }, > >>> + ), > >>> + PveSettingsSection( > >>> + title: 'LEGAL', > >>> + children: [ > >>> + PveSettingsItem( > >>> + titleString: 'Privacy Policy', > >>> + leadingIcon: Icons.privacy_tip_outlined, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel