From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 172701FF17A
	for <inbox@lore.proxmox.com>; Fri,  4 Jul 2025 16:40:32 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 783943A88C;
	Fri,  4 Jul 2025 16:41:11 +0200 (CEST)
Mime-Version: 1.0
Date: Fri, 04 Jul 2025 16:40:37 +0200
Message-Id: <DB3CKK74Y8SL.3MC1LJ87XT7MW@noor>
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, "Proxmox VE development
 discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.14.0
References: <20250703111939.52692-1-s.shaji@proxmox.com>
 <7de107d7-c2fe-4f22-976d-295cd9263a0c@proxmox.com>
In-Reply-To: <7de107d7-c2fe-4f22-976d-295cd9263a0c@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.280 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.218 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: settings: add
 privacy policy url link in settings screen
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Thu Jul 3, 2025 at 4:00 PM CEST, Dominik Csapak wrote:
> > +      backgroundColor: Theme.of(context).colorScheme.surfaceContainer,
>
> this change seems to be unrelated?
This was intended. The change was made to match the backgroundColor of 
`ProxmoxLoginSelector`. Previously it was using the default scaffold 
backgroundColor. 
>
> >         appBar: AppBar(
> >           title: const Text('Settings'),
> >         ),
> > @@ -45,6 +51,32 @@ class _ProxmoxGeneralSettingsFormState
> >                                 ProxmoxGeneralSettingsModel.fromLocalStorage();
> >                           });
> >                         },
> > +                    ),
> > +                    PveSettingsSection(
> > +                      title: 'LEGAL',
> > +                      children: [
> > +                        PveSettingsItem(
> > +                          titleString: 'Privacy Policy',
> > +                          leadingIcon: Icons.privacy_tip_outlined,


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel