From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7C9DB1FF164 for ; Fri, 4 Jul 2025 14:10:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD458373CA; Fri, 4 Jul 2025 14:11:04 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 04 Jul 2025 14:11:02 +0200 Message-Id: From: "Shan Shaji" To: "Thomas Lamprecht" , "Proxmox VE development discussion" , "Dominik Csapak" X-Mailer: aerc 0.14.0 References: <20250703111939.52692-1-s.shaji@proxmox.com> <7de107d7-c2fe-4f22-976d-295cd9263a0c@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.284 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: settings: add privacy policy url link in settings screen X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Got it. Thanks for sharing. On Fri Jul 4, 2025 at 11:34 AM CEST, Thomas Lamprecht wrote: > Am 04.07.25 um 09:31 schrieb Dominik Csapak: > >> > >> This is just my doubt. Can i ask why we seperated the > >> proxmox_login_manager as a seperate package? > > I'm not sure why we did this, but my guess would be that it was planned to maybe have > > multiple apps in the future? > > > > @Tim i think you were intially the one doing that, do you remember why we did the split? > > > > For having a shared basis for other products, there is a prototype for > PBS on the staff repos IIRC. While we do not plan to develop that further > at the moment, having to split it out again in the future is definitively > quite a bit of extra work, while keeping it split shouldn't be so hard > I think. So, while not a must, I'd I'd keep it split for the time being, > if there are no bigger reasons speaking against that. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel