From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1DCF21FF17C for <inbox@lore.proxmox.com>; Wed, 11 Jun 2025 12:44:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C59A93E170; Wed, 11 Jun 2025 12:45:18 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 11 Jun 2025 12:44:45 +0200 Message-Id: <DAJN5FOTU2VU.1K2DHZWUA99SC@proxmox.com> To: "Stefan Hanreich" <s.hanreich@proxmox.com> From: "Christoph Heiss" <c.heiss@proxmox.com> X-Mailer: aerc 0.20.1 References: <20250424111941.730528-1-c.heiss@proxmox.com> <20250424111941.730528-8-c.heiss@proxmox.com> <da8f3a27-7109-4f3b-98bc-5a797cb26ac5@proxmox.com> In-Reply-To: <da8f3a27-7109-4f3b-98bc-5a797cb26ac5@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v2 7/13] fix #5180: libexec: add QEMU dbus-vmstate daemon for migrating conntrack X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Tue Jun 3, 2025 at 11:34 AM CEST, Stefan Hanreich wrote: > On 4/24/25 13:19, Christoph Heiss wrote: >> +sub Load { >> + my ($self, $bytes) = @_; >> + >> + my $len = scalar(@$bytes); >> + return if $len <= 1; # see also the `Save` method >> + >> + my $text = pack('c*', @$bytes); >> + >> + eval { >> + PVE::Tools::run_command( >> + ['conntrack', '--load-file', '-'], >> + input => $text, >> + ); >> + }; >> + if (my $err = $@) { > > nit: could just use $@ directly here? some additional occurences below Yeah indeed, just bit a muscle memory on my side, since it also avoids accidentally overwriting/propagating the wrong error, in case $@ get's set again, with $@ being quite magic. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel