From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 675861FF165
	for <inbox@lore.proxmox.com>; Thu, 22 May 2025 11:33:03 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 13524313E5;
	Thu, 22 May 2025 11:33:04 +0200 (CEST)
Mime-Version: 1.0
Date: Thu, 22 May 2025 11:33:00 +0200
Message-Id: <DA2L3LU8O2RD.1E7K4LKL39R9O@noor>
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.14.0
References: <20250519125959.7189-1-s.shaji@proxmox.com>
 <81df0520-361b-44c4-8b22-9499723e9cca@proxmox.com>
In-Reply-To: <81df0520-361b-44c4-8b22-9499723e9cca@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.337 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: assets: update
 flutter app icons in iOS with proxmox icons
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Thank you so much for the review. The changes in the `Contents.json` was
done by Xcode when i dragged and dropped the icons into the asset
catalog of Xcode. I will create another patch by removing all the
formatting and reordering changes from the `Contents.json` file. 

On Wed May 21, 2025 at 1:27 PM CEST, Dominik Csapak wrote:
> while i can't test the changes for ios, the images look good,
> one question for my curiosity:
>
> what triggered the changes in the Contents.json ?
>
> AFAICS it's just reordering the properties + whitespace changes, which
> make it hard to see if there was any actual change to the content...
>
> not that I'm against it, but we should probably not unnecessarily touch these files,
> except some tooling (e.g. from flutter) autoformats these or there
> are real changes...






















































































































































































































































_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel