From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 424641FF17C
	for <inbox@lore.proxmox.com>; Wed, 30 Apr 2025 10:32:09 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 530E91D29A;
	Wed, 30 Apr 2025 10:32:19 +0200 (CEST)
Mime-Version: 1.0
Date: Wed, 30 Apr 2025 10:32:14 +0200
Message-Id: <D9JU13E2HYLK.2FY2Z8EQHC0KI@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Alexander Abraham" <a.abraham@proxmox.com>
X-Mailer: aerc 0.20.1
References: <20250429150757.130996-1-a.abraham@proxmox.com>
 <20250429150757.130996-4-a.abraham@proxmox.com>
In-Reply-To: <20250429150757.130996-4-a.abraham@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.029 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH manager 1/1] fix #4281: manager: Enabled
 logging in with Open ID
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

The commit message title should always be in present tense (handy
shortcut to remember: the commit/patch will *change* it, but it hasn't
been changed *before* the commit/patch).

Applies to the other patches in the series as well - see also our
developer documentation on that matter [0].

On Tue Apr 29, 2025 at 5:07 PM CEST, Alexander Abraham wrote:
> This commit adds an authorization flow for logging
> in a user using Open ID on the PVE web frontend in
> the mobile view.

"This commit [..]" is redundant, since the context is already clear :^)

Didn't really review the patch further, so if there's some other
important detail, it should be mentioned as well.

[0] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>  www/mobile/Login.js | 148 ++++++++++++++++++++++++++++++++++----------
>  1 file changed, 116 insertions(+), 32 deletions(-)
>
> diff --git a/www/mobile/Login.js b/www/mobile/Login.js
> index 06c8b3d4..05038036 100644
> --- a/www/mobile/Login.js
> +++ b/www/mobile/Login.js
> @@ -1,8 +1,10 @@
> +/ https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/manager6/Workspace.js;h=922e01df86718e8fc89ce5835f81d21f6d849b81;hb=HEAD
> +

Unintentional copy-paste I assume?



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel