From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id D1B331FF16F
for <inbox@lore.proxmox.com>; Tue, 29 Apr 2025 10:24:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 41AD4643B;
Tue, 29 Apr 2025 10:24:24 +0200 (CEST)
Mime-Version: 1.0
Date: Tue, 29 Apr 2025 10:23:50 +0200
Message-Id: <D9IZ84LXPBV9.1HWY3EOEB7F4B@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>, "Shan
Shaji" <s.shaji@proxmox.com>
X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty
References: <20250428140326.65005-1-s.shaji@proxmox.com>
In-Reply-To: <20250428140326.65005-1-s.shaji@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.018 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] navigation: replace
deprecated `onPopInvoked` callback
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Mon Apr 28, 2025 at 4:03 PM CEST, Shan Shaji wrote:
> The `onPopInvoked` callback is deprecated as of
> Flutter v3.22.0-12.0.pre. This patch replaces it
> with the `onPopInvokedWithResult` callback.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
> lib/pages/main_layout_slim.dart | 2 +-
> lib/states/pve_node_overview_state.dart | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
> index 322bcac..8c4cacb 100644
> --- a/lib/pages/main_layout_slim.dart
> +++ b/lib/pages/main_layout_slim.dart
> @@ -71,7 +71,7 @@ class _MainLayoutSlimState extends State<MainLayoutSlim> {
> ],
> child: PopScope(
> canPop: false,
> - onPopInvoked: (didPop) async {
> + onPopInvokedWithResult: (didPop, _) {
is eremoving the `async` keyword here intentional? if so, it might be
worth documenting why you removed it.
> if (didPop || pageSelector.value != 0) {
> if (pageSelector.value != 0) pageSelector.add(0);
> return;
> diff --git a/lib/states/pve_node_overview_state.dart b/lib/states/pve_node_overview_state.dart
> index 132764c..64353f8 100644
> --- a/lib/states/pve_node_overview_state.dart
> +++ b/lib/states/pve_node_overview_state.dart
> @@ -1,5 +1,3 @@
> -library pve_node_overview_state;
> -
this seems unrelated, did you mean to remove the library declaration of
this files?
> import 'package:built_collection/built_collection.dart';
> import 'package:built_value/built_value.dart';
> import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel