From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 7126A1FF165
	for <inbox@lore.proxmox.com>; Thu, 24 Apr 2025 14:16:28 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id DCD276E1F;
	Thu, 24 Apr 2025 14:16:33 +0200 (CEST)
Mime-Version: 1.0
Date: Thu, 24 Apr 2025 14:15:58 +0200
Message-Id: <D9EV14VROB66.3AVL7KTTFLIR7@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty
References: <20250424105441.76823-1-s.shaji@proxmox.com>
In-Reply-To: <20250424105441.76823-1-s.shaji@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.132 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 POISEN_SPAM_PILL          0.1 Meta: its spam
 POISEN_SPAM_PILL_1        0.1 random spam to be learned in bayes
 POISEN_SPAM_PILL_3        0.1 random spam to be learned in bayes
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] gitignore: add
 generated dart files
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Shan Shaji <s.shaji@proxmox.com>,
 pve-devel <pve-devel-bounces@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Thu Apr 24, 2025 at 12:54 PM CEST, Shan Shaji wrote:
> Omit `devtools_options.yaml` file and generated dart files
> from source control.
>
> `devtools_options.yaml` file is a config file for storing the
> extension enablement states of flutter dev tools. By adding `devtools_options.yaml`
> as an entry in the `.gitignore` file, the configurations will be seperate for each developer.

just a small nit, the two lines above are longer than the 72 characters
suggested by our commit message style guide [1]. please make sure that
whatever editor you use enforce the hard line wrapping here correctly :)

[1]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 3c88cc5..5e91008 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -43,3 +43,6 @@ app.*.map.json
>  /android/app/debug
>  /android/app/profile
>  /android/app/release
> +
> +*.g.dart
> +devtools_options.yaml
> \ No newline at end of file



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel