From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 7BF7F1FF162
	for <inbox@lore.proxmox.com>; Mon,  7 Apr 2025 12:49:07 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B7EEC3C0E2;
	Mon,  7 Apr 2025 12:49:05 +0200 (CEST)
Mime-Version: 1.0
Date: Mon, 07 Apr 2025 12:49:03 +0200
Message-Id: <D90CJBJUO0Y6.CN9YRQ0BH833@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>
X-Mailer: aerc 0.20.1
References: <20250407091647.202800-1-c.heiss@proxmox.com>
 <174401995303.2626354.5380020422632639795.b4-ty@proxmox.com>
In-Reply-To: <174401995303.2626354.5380020422632639795.b4-ty@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v2 1/2] window: migrate: make all
 user-visible strings translatable
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Mon Apr 7, 2025 at 12:06 PM CEST, Thomas Lamprecht wrote:
>
> On Mon, 07 Apr 2025 11:16:27 +0200, Christoph Heiss wrote:
>> Quite a few user-visible strings in the dialog currently are not using
>> gettext(), thus not making them translatable.
>>
>> While at it, also remove some contractions from error/warning messages.
>> Not strictly necessary per our style guide, but it avoids escaping
>> single quotes and reads quite a bit nicer IMHO.
>>
>> [...]
>
> Applied, fixed the subject to start with a `ui` tag and then
> use a slightly more verbose `guest migrate window` second
> level tag, thanks!

Thanks! Not sure how I missed the `ui:` commit tag on this, will do a
double-take on this matter in the future.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel