From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id B8AC91FF172
	for <inbox@lore.proxmox.com>; Tue,  1 Apr 2025 16:05:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 21558345E1;
	Tue,  1 Apr 2025 16:05:15 +0200 (CEST)
Date: Tue, 01 Apr 2025 16:05:12 +0200
Message-Id: <D8VCY8D7P7R4.1D4H6G5HYWM8Y@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>
Mime-Version: 1.0
X-Mailer: aerc 0.20.1
References: <20250327151718.1084841-1-c.heiss@proxmox.com>
 <02e7804d-ab22-4c30-b44f-ad6c032acc05@proxmox.com>
In-Reply-To: <02e7804d-ab22-4c30-b44f-ad6c032acc05@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.031 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer 0/6] fix #5811: add option to
 retrieve FQDN from DHCP configuration
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Tue Apr 1, 2025 at 3:45 PM CEST, Daniel Kral wrote:
[..]
> Just wanted to ask: Would it make sense to also have a fallback for the
> hostname if the DHCP server does only provide a domain but no hostname
> here or should the DHCP provide the full FQDN?

I thought about that, but it really does not make sense.

Setting `global.fqdn.source = "from-dhcp"` is a option that must be
actively set by the user and it just does not make sense, if the DHCP
does not provide (at least) a hostname.

At this point, the hostname can also be set directly in the answer file
as before, instead of using this option.

>
> Else, consider this series as:
>
> Tested-by: Daniel Kral <d.kral@proxmox.com>

Thanks for testing!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel