From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 968D91FF172 for <inbox@lore.proxmox.com>; Tue, 1 Apr 2025 15:26:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5DCE532766; Tue, 1 Apr 2025 15:26:21 +0200 (CEST) Date: Tue, 01 Apr 2025 15:25:48 +0200 Message-Id: <D8VC42F4R5VW.23126SXQH3CVG@proxmox.com> To: "Daniel Kral" <d.kral@proxmox.com> From: "Christoph Heiss" <c.heiss@proxmox.com> Mime-Version: 1.0 X-Mailer: aerc 0.20.1 References: <20250327151718.1084841-1-c.heiss@proxmox.com> <20250327151718.1084841-7-c.heiss@proxmox.com> <bf26e451-0771-49c3-9ea7-2064c0a9835b@proxmox.com> In-Reply-To: <bf26e451-0771-49c3-9ea7-2064c0a9835b@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 6/6] fix #5811: auto: add option to retrieve FQDN from DHCP configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Thanks for testing! On Tue Apr 1, 2025 at 3:15 PM CEST, Daniel Kral wrote: [..] > Just tried to apply this, and it seems like the diff for the JSON files > is malformed as it splits the changes at roughly 1000 characters for the > changes to run-env*.json files: > > * run-env-info.json > * no_fqdn_from_dhcp.run-env.json > * fqdn_from_dhcp_no_default_domain.run-env.json Right, thanks for noticing! That definitely is broken, unfortunately. Probably a hard-limit somewhere with 1000 characters per line along the line. The file directly from `git format-patch` looks fine, with no extra newlines. Sent the patches using `git send-email` as usual, so not sure where it went wrong. I'll see if I can reproduce it locally for me and fix it up for a v2. (Otherwise I'll just pretty-print/format these JSON files for v2.) > > I'm not sure what could have caused this, but after manually fixing > this, the rest of the patch applies cleanly and the tests run fine. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel