From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 92DB11FF15C
	for <inbox@lore.proxmox.com>; Wed, 26 Mar 2025 11:21:22 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 16FBD33C4B;
	Wed, 26 Mar 2025 11:21:18 +0100 (CET)
Mime-Version: 1.0
Date: Wed, 26 Mar 2025 11:20:45 +0100
Message-Id: <D8Q4F466MP1B.54FKSGGJF7WL@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
 "Alexander Zeidler" <a.zeidler@proxmox.com>
From: "Max Carrara" <m.carrara@proxmox.com>
X-Mailer: aerc 0.18.2-0-ge037c095a049
References: <20250205100850.3-1-a.zeidler@proxmox.com>
 <b5662161-9f81-4a67-b3de-a1246f1b272c@proxmox.com>
In-Reply-To: <b5662161-9f81-4a67-b3de-a1246f1b272c@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.074 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for
 use in troubleshooting section
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Mon Mar 24, 2025 at 5:42 PM CET, Aaron Lauterer wrote:
>
>
> On  2025-02-05  11:08, Alexander Zeidler wrote:
> > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> > ---
> > v2:
> > * add two missing anchors to be usable via xref
> > 
> >   pve-disk-health-monitoring.adoc | 1 +
> >   pveceph.adoc                    | 8 ++++++++
> >   pvecm.adoc                      | 1 +
> >   3 files changed, 10 insertions(+)
> > 
> >
> thanks for the work to extend the docs!
>
> applied with some changes and follow-ups:
>
> * we do not want to break the anchor to the ceph recommendations. This 
> anchor is in use to redirect customers and users to ceph requirements. 
> Yes it is ugly, but we cannot change it so we keep it.
> * I do not think that inline CLI commands are a good idea as they are 
> make the paragraph messy and harder to read and are hard to copy&paste. 
> Therefore, I rephrased those parts to have them in their own code blocks.
> * rephrased the Destroy OSD section, mainly to also place the CLI 
> commands into code blocks and a few other things you can see in the 
> follow up commit.

Aw, without my R-b and T-b tags, unfortunately :(

Is there any reason in particular that they weren't added?

>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel