From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 9DF011FF15C
for <inbox@lore.proxmox.com>; Wed, 19 Mar 2025 11:16:07 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 12A666933;
Wed, 19 Mar 2025 11:15:55 +0100 (CET)
Mime-Version: 1.0
Date: Wed, 19 Mar 2025 11:15:51 +0100
Message-Id: <D8K5XK48SBUA.2F2K2QARQWH3N@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.1
References: <20250304104954.191259-1-m.sandoval@proxmox.com>
In-Reply-To: <20250304104954.191259-1-m.sandoval@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.028 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer] gui: always set
visible-child-name on disk dialog
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote:
> Whenever a filesystem is selected we show the size selection stack page.
>
> At the moment entering any raid setup, then entering the Advanced
> Options page and then selecting any non-raid setup will show the
> raiddisk page since it is still the visible child.
While testing this, I cannot seem to reproduce the original problem on
the latest PVE 8.3-1 ISO.
In the GUI, clicking on "Options" besides the target harddisk, then in
the dialog selecting e.g. "zfs (RAID1)", going to the "Advanced Options"
tab and then selecting e.g. "ext4" above, yields the normal disk sizing
options tab as expected.
On the main disk selection page, the dropdown is also updated
accordingly.
Or is some other combination of inputs required to trigger this bug?
This is just based upon the patch description.
>
> Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> proxinstall | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/proxinstall b/proxinstall
> index fe7e29f..5e61e9b 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -1358,6 +1358,7 @@ sub create_hdoption_view {
> $options_stack->set_visible_child_name("raiddisk");
> } else {
> $target_hd_label->set_text("Target Harddisk");
> + $options_stack->set_visible_child_name("hdsize");
> }
>
> if ($raid) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel