From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 16D4D1FF165 for <inbox@lore.proxmox.com>; Wed, 12 Mar 2025 12:10:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE094293F; Wed, 12 Mar 2025 12:10:16 +0100 (CET) Mime-Version: 1.0 Date: Wed, 12 Mar 2025 12:09:43 +0100 Message-Id: <D8E8OZGX1HI7.QH6MQS4GLOTI@proxmox.com> To: "Roland Kammerer" <roland.kammerer@linbit.com>, "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> From: "Max Carrara" <m.carrara@proxmox.com> X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <mailman.122.1738918965.293.pve-devel@lists.proxmox.com> <56159490.3085.1738919922263@webmail.proxmox.com> <Z6X9vOv2lCsvTy3o@arm64> <D81GW402I9IT.2I6IX7N77DSJQ@proxmox.com> <Z8qtOTycFZpN5bpL@arm64> In-Reply-To: <Z8qtOTycFZpN5bpL@arm64> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Fri Mar 7, 2025 at 9:24 AM CET, Roland Kammerer wrote: > Hi Max, > > took me a bit longer than expected, but here we go... > Thanks a lot for your detailed feedback, it's highly appreciated! You'll probably be delighted that a couple of the things you mentioned are already in progress: - We're in the process of documenting the PVE::Storage::Plugin API; I'll also see if I can address some of your points there already. We can't change the API right away of course, so I'd personally rather have those "historical" things documented. This will also include what's mandatory to implement, what's optional, what you shouldn't override at all, etc. Also the specific cases in which you'd probably want to implement (or not implement something). - There's also an example storage plugin we're currently writing, which basically does as you suggested. What I have in mind there is that we'd show you how to build that specific plugin step-by-step while also providing the complete source of the final plugin as well as a package so you can just install it and see it in action, too. API changes of course aren't as easy / straightforward to make, and there's also the question of whether they'd actually be worth it overall. But, I've nevertheless noted those things down -- right now the documentation is a much higher priority, though. At least from my side. The testing suite you mentioned sounds interesting; I'll add that to my backlog as well and give it some ponderment. If you have any concrete ideas regarding this, feel free to toss them my way! Last but not least, the GUI integration is a very good point. I can't promise anything in that regard yet, but I'm also taking note here. Definitely something that can be improved. Thanks again for your detailed feedback, it's really valuable! If there are ever any other issues you come across, feel free to let me know here in this thread. I have taken note of everything you said. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel