From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN
Date: Mon, 10 Mar 2025 16:29:58 +0100 [thread overview]
Message-ID: <D8COZ5HOR1HV.19VU9SX7JX94H@proxmox.com> (raw)
In-Reply-To: <20250228140136.124286-2-s.hanreich@proxmox.com>
On Fri Feb 28, 2025 at 3:01 PM CET, Stefan Hanreich wrote:
> ASNs are 32-bit unsigned integers where the maximum value is
> 4294967295.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> index c245ea2..78c9798 100644
> --- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> +++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> @@ -24,7 +24,7 @@ sub properties {
> type => 'integer',
> description => "autonomous system number",
> minimum => 0,
> - maximum => 4294967296
> + maximum => 4294967295
just a small nit, it might be nicer to express that as `2**32-1` if
that's an option.
> },
> peers => {
> description => "peers address list.",
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-10 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 14:01 [pve-devel] [PATCH network 0/5] Improve documentation for SDN API endpoints used by PDM Stefan Hanreich
2025-02-28 14:01 ` [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN Stefan Hanreich
2025-03-10 15:29 ` Shannon Sterz [this message]
2025-03-11 5:53 ` Matthieu Pignolet via pve-devel
2025-03-11 10:50 ` DERUMIER, Alexandre via pve-devel
2025-02-28 14:01 ` [pve-devel] [PATCH pve-network 2/5] api: add state standard option Stefan Hanreich
2025-02-28 14:01 ` [pve-devel] [PATCH pve-network 3/5] api: controllers: update schema of endpoints Stefan Hanreich
2025-02-28 14:01 ` [pve-devel] [PATCH pve-network 4/5] api: vnets: " Stefan Hanreich
2025-02-28 14:01 ` [pve-devel] [PATCH pve-network 5/5] api: zones: " Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8COZ5HOR1HV.19VU9SX7JX94H@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox