From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 70E511FF15E
for <inbox@lore.proxmox.com>; Tue, 25 Feb 2025 11:25:49 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 9AF001A120;
Tue, 25 Feb 2025 11:25:47 +0100 (CET)
Mime-Version: 1.0
Date: Tue, 25 Feb 2025 11:25:13 +0100
Message-Id: <D81GCQLG3ZEO.3DCCHMZRAKYF@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.0
References: <20250117075117.195550-1-c.heiss@proxmox.com>
In-Reply-To: <20250117075117.195550-1-c.heiss@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_CSS_A 0.1 Contains URL's A record listed in the Spamhaus CSS blocklist
[195.154.200.217]
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs] config: fix a few clippy
warnings
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Ping, still applies.
FWIW, no new warnings popped up with 1.85.
On Fri Jan 17, 2025 at 8:51 AM CET, Christoph Heiss wrote:
> .. as newly introduced with 1.84.
>
> Namely `elided_named_lifetimes` for the change of `SdnConfig` and
> `clippy::needless_lifetimes` for the rest.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-ve-config/src/firewall/parse.rs | 6 +++---
> proxmox-ve-config/src/sdn/config.rs | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/proxmox-ve-config/src/firewall/parse.rs b/proxmox-ve-config/src/firewall/parse.rs
> index 7bf00c0..8cf4757 100644
> --- a/proxmox-ve-config/src/firewall/parse.rs
> +++ b/proxmox-ve-config/src/firewall/parse.rs
> @@ -316,7 +316,7 @@ pub mod serde_option_log_ratelimit {
> #[derive(Clone, Copy, Debug)]
> pub struct SomeStrDeserializer<'a, E>(serde::de::value::StrDeserializer<'a, E>);
>
> -impl<'de, 'a, E> serde::de::Deserializer<'de> for SomeStrDeserializer<'a, E>
> +impl<'de, E> serde::de::Deserializer<'de> for SomeStrDeserializer<'_, E>
> where
> E: serde::de::Error,
> {
> @@ -379,7 +379,7 @@ impl<'a> From<&'a str> for SomeStr<'a> {
> }
> }
>
> -impl<'de, 'a, E> serde::de::IntoDeserializer<'de, E> for SomeStr<'a>
> +impl<'a, E> serde::de::IntoDeserializer<'_, E> for SomeStr<'a>
> where
> E: serde::de::Error,
> {
> @@ -465,7 +465,7 @@ impl From<String> for SomeString {
> }
> }
>
> -impl<'de, E> serde::de::IntoDeserializer<'de, E> for SomeString
> +impl<E> serde::de::IntoDeserializer<'_, E> for SomeString
> where
> E: serde::de::Error,
> {
> diff --git a/proxmox-ve-config/src/sdn/config.rs b/proxmox-ve-config/src/sdn/config.rs
> index 7ee1101..880efc2 100644
> --- a/proxmox-ve-config/src/sdn/config.rs
> +++ b/proxmox-ve-config/src/sdn/config.rs
> @@ -544,7 +544,7 @@ impl SdnConfig {
> pub fn ipsets<'a>(
> &'a self,
> filter: Option<&'a Allowlist<VnetName>>,
> - ) -> impl Iterator<Item = Ipset> + '_ {
> + ) -> impl Iterator<Item = Ipset> + 'a {
> self.zones
> .values()
> .flat_map(|zone| zone.vnets())
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel