From: "Max Carrara" <m.carrara@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 pve-common 11/12] introduce PVE::Filesystem
Date: Mon, 03 Feb 2025 15:21:58 +0100 [thread overview]
Message-ID: <D7IVM0QITDXH.3OBLZ5I6GP74W@proxmox.com> (raw)
In-Reply-To: <dc182f1d-3224-4d14-ba48-3eb672d834fc@proxmox.com>
On Fri Jan 31, 2025 at 1:44 PM CET, Fiona Ebner wrote:
> Am 09.01.25 um 15:48 schrieb Max Carrara:
> > +
> > +sub fs_canonicalize : prototype($) {
> > + my ($path) = @_;
> > +
> > + croak "\$path is undef" if !defined($path);
> > +
> > + my $canonicalized_path = Cwd::abs_path($path);
> > +
> > + croak "failed to canonicalize path: $!" if !defined($canonicalized_path);
> > +
> > + return $canonicalized_path;
> > +}
> > +
>
> Missing the 1; at the end of module
Woops, thanks for spotting this! Will correct that.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-03 14:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 14:48 [pve-devel] [PATCH v3 pve-common 00/12] Introduce and Package PVE::Path & PVE::Filesystem Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path Max Carrara
2025-01-31 12:23 ` Fiona Ebner
2025-01-31 12:33 ` Fiona Ebner
2025-02-03 14:21 ` Max Carrara
2025-02-03 15:42 ` Fiona Ebner
2025-02-03 16:45 ` Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 02/12] test: add directory for tests of PVE::Path module Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 03/12] test: add tests for path_is_absolute and path_is_relative of PVE::Path Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 04/12] test: add tests for path_components " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 05/12] test: add tests for path_join " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 06/12] test: add tests for path_push " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 07/12] test: add tests for path_parent " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 08/12] test: add tests for path_starts_with, path_ends_with, path_equals Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 09/12] test: add tests for file path operation functions of PVE::Path Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 10/12] test: add tests for path_normalize " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 11/12] introduce PVE::Filesystem Max Carrara
2025-01-31 12:44 ` Fiona Ebner
2025-02-03 14:21 ` Max Carrara [this message]
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 12/12] debian: introduce package libproxmox-fs-path-utils-perl Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7IVM0QITDXH.3OBLZ5I6GP74W@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox