From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 71CBD1FF165 for <inbox@lore.proxmox.com>; Wed, 29 Jan 2025 10:34:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0C251D33C; Wed, 29 Jan 2025 10:34:32 +0100 (CET) Mime-Version: 1.0 Date: Wed, 29 Jan 2025 10:34:29 +0100 Message-Id: <D7EGD6JHPNGU.333J1CVQM1KXY@proxmox.com> From: "Christoph Heiss" <c.heiss@proxmox.com> To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> X-Mailer: aerc 0.18.2 References: <20241205140721.207021-1-d.kral@proxmox.com> <f7b6603b-4423-464e-8fc2-0df5ed956650@proxmox.com> In-Reply-To: <f7b6603b-4423-464e-8fc2-0df5ed956650@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC PATCH installer] fix #5973: auto: first boot: allow snake- and kebabcased property names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Tue Jan 28, 2025 at 3:38 PM CET, Thomas Lamprecht wrote: > Am 05.12.24 um 15:07 schrieb Daniel Kral: [..] > > - with `cert-fingerprint` (which works correctly as expected), and > > - with `cert_fingerprint` (which will fail at a parser error with the > > newest Proxmox VE 8.3-1 ISO). > > This is a bit worded like that behavior would be a regression, but it > isn't AFAICT as this was always kebab-case from when being added in > commit 6526662 ("fix #5579: auto-installer: add optional first-boot hook > script"); or am I overlooking something? To provide context; since I actually introduced this option/code: That was indeed intentionally kebab-cased, as we prefer that style for new code - as explained below. [..] > > -#[serde(rename_all = "kebab-case", deny_unknown_fields)] > > +#[serde(deny_unknown_fields)] > > But we prefer kebab-case for any public API/CLI parameter for modern code; > so shouldn't we rather to the opposite, transform all other (de)serializable > configs to use kebab-case with backward-compat aliases for the cases it > matters? I'd prefer that variant too, FWIW. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel