From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id A958F1FF168
	for <inbox@lore.proxmox.com>; Tue, 21 Jan 2025 13:09:34 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 61BBB7F5E;
	Tue, 21 Jan 2025 13:09:31 +0100 (CET)
Mime-Version: 1.0
Date: Tue, 21 Jan 2025 13:08:44 +0100
Message-Id: <D77QMXMBPE6E.2SQ10AEIUDF1E@proxmox.com>
From: "Alexander Zeidler" <a.zeidler@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
References: <20250120143513.346231-1-a.lauterer@proxmox.com>
In-Reply-To: <20250120143513.346231-1-a.lauterer@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.087 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH docs] qm,
 vzdump: add notes regarding backups of windows and VSS
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Mon Jan 20, 2025 at 3:35 PM CET, Aaron Lauterer wrote:
> VSS in windows guests with additional backup software in the guest can
> cause problems. By now the guest agent does support to use a different
> VSS option. This way, one can switch to one that does not interfere with
> other backup solutions.
>
> Mention it in the docs and link to the wiki article that explains it.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
Two formatting suggestions inline, otherwise consider this:
Reviewed-by: Alexander Zeidler <a.zeidler@proxmox.com>

>  qm.adoc     | 13 +++++++++----
>  vzdump.adoc |  4 ++++
>  2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/qm.adoc b/qm.adoc
> index 4bb8f2c..660047a 100644
> --- a/qm.adoc
> +++ b/qm.adoc
> @@ -1355,14 +1355,19 @@ that calling 'fs-freeze' with some SQL Servers triggers VSS to call the SQL
>  Writer VSS module in a mode that breaks the SQL Server backup chain for
>  differential backups.
>  
> -For such setups you can configure {pve} to not issue a freeze-and-thaw cycle on
> +There are two options on how to handle such a situation.
> +
> +1. Configure the QEMU Guest Agent to use a different VSS variant that does not
> +interfere with other VSS users. The https://pve.proxmox.com/wiki/VM_Backup_Consistency[{pve} wiki]
> +has more details.
> +2. Alternatively, you can configure {pve} to not issue a freeze-and-thaw cycle on
>  backup by setting the `freeze-fs-on-backup` QGA option to `0`. This can also be
>  done via the GUI with the 'Freeze/thaw guest filesystems on backup for
>  consistency' option.
>  
> -IMPORTANT: Disabling this option can potentially lead to backups with inconsistent
> -filesystems and should therefore only be disabled if you know what you are
> -doing.
> +IMPORTANT: Disabling this option can potentially lead to backups with
> +inconsistent filesystems. Therefore, adapting the QEMU Guest Agent
> +configuration in the guest is the preferred option.
Since there is now a numbered list, it may make sense to move the
modified "Important" admonition to option 2 (so indented).

>  
>  Troubleshooting
>  ^^^^^^^^^^^^^^^
> diff --git a/vzdump.adoc b/vzdump.adoc
> index aecb353..0708d07 100644
> --- a/vzdump.adoc
> +++ b/vzdump.adoc
> @@ -96,6 +96,10 @@ a background QEMU process, a stopped VM will appear as running for a
>  short amount of time while the VM disks are being read by QEMU.
>  However the VM itself is not booted, only its disk(s) are read.
>  
> +NOTE: On Windows guests it is necessary to configure the guest agent if another
> +backup software is used within the guest. See xref:qm_qga_fsfreeze[Freeze & Thaw]
> +in the guest agent section for more details.
For me it seems more appropriate to put the new note under "snapshot
mode" (so indented), since it is only relevant there.

> +
>  .Backup modes for Containers:
>  
>  `stop` mode::



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel