From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 969F61FF164 for <inbox@lore.proxmox.com>; Fri, 20 Dec 2024 12:06:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 184AC3982; Fri, 20 Dec 2024 12:06:44 +0100 (CET) Mime-Version: 1.0 Date: Fri, 20 Dec 2024 12:06:41 +0100 Message-Id: <D6GH9ZGO95MV.J7G0QKHKE6J0@proxmox.com> To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>, "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> From: "Max Carrara" <m.carrara@proxmox.com> X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20241219183143.526267-1-m.carrara@proxmox.com> <20241219183143.526267-3-m.carrara@proxmox.com> <4990a4b4-5027-4db2-9909-d36af8a54a07@proxmox.com> In-Reply-To: <4990a4b4-5027-4db2-9909-d36af8a54a07@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v1 pve-common 2/4] add tests for PVE::Path X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Thu Dec 19, 2024 at 8:08 PM CET, Thomas Lamprecht wrote: > Am 19.12.24 um 19:31 schrieb Max Carrara: > > This commit adds a plethora of parameterized tests for all functions > > of PVE::Path (except aliases). This surmounts to 1050 tests being run > > in total. Some of these tests might perhaps be redundant, but the goal > > here was to be better safe than sorry and really make sure that > > nothing slips through. > > IMO that's a little bit contradictory, as redundant tests, or not knowing > how much redundancy there is making me a bit question if this is really > worth it. I'd rather see much fewer tests but with a clear plan/idea for > what they are for; as of is this is not really reviewable and without > knowing how they got created and how much it was made sure that we do not > test ten times the same thing. > > I do not want to say you do, but would like some more reasoning here than > "trust me bro" and if we can have 100, or even less, tests with the same > coverage it would be a big improvement, as that makes them much more > maintainable. Hmm, fair point. I'll see if I can slim down the amount of tests and instead be really particular about what's being tested. I'll also split this commit up into multiple smaller ones and explain my reasonings for each. There's of course an idea on how I'm testing things here, but I agree that it should be laid out better (or perhaps actually be laid out in the first place). Thanks for your feedback, will address this in v2! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel