From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 45FBC1FF170 for <inbox@lore.proxmox.com>; Tue, 17 Dec 2024 11:25:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C70091D018; Tue, 17 Dec 2024 11:26:04 +0100 (CET) Mime-Version: 1.0 Date: Tue, 17 Dec 2024 11:26:01 +0100 Message-Id: <D6DWJ7ZFFZO7.2P2Y42U1UBIBK@proxmox.com> To: "Daniel Kral" <d.kral@proxmox.com> From: "Christoph Heiss" <c.heiss@proxmox.com> X-Mailer: aerc 0.18.2 References: <20241211161402.236144-1-d.kral@proxmox.com> In-Reply-To: <20241211161402.236144-1-d.kral@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [unconfigured.sh] Subject: Re: [pve-devel] [PATCH installer] fix #5984: unconfigured: do not reboot if auto-installer fails by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Thanks for tackling this! But this still doesn't really fix the issue by honoring the `global.reboot_on_error` flag in any way, but just inverts the current behaviour? I.e. now it just always drops into the a shell, w/o ever auto-rebooting, even if `global.reboot_on_error = true`. This would need some sort of proper flag(-file) to indicate to `unconfigured.sh` whether to reboot on errors in auto-installer mode or not -- along the lines of that proxmox-auto-installer could e.g. touch /run/proxmox-reboot-on-error if `reboot_on_error` is set and unconfigured.sh can then just check for that files existence. Same goes for when proxmox-post-hook fails, as the reboot is also unconditional if that fails. Both should honor the flag set in the answer file. Waiting ~30s before auto-rebooting on errors is a good thing IMHO, so I'd keep that. On Wed Dec 11, 2024 at 5:14 PM CET, Daniel Kral wrote: > [..] > diff --git a/unconfigured.sh b/unconfigured.sh > index 070cf33..f9cc9de 100755 > --- a/unconfigured.sh > +++ b/unconfigured.sh > @@ -260,6 +260,9 @@ elif [ $start_auto_installer -ne 0 ]; then > echo "waiting 30s to allow gathering the error before reboot." > sleep 30 > fi > + else > + # simulate a trap to `err_reboot` if the auto-installer fails > + err_reboot Since the function is now called here directly, the shellcheck `disable=SC2317` directive can now be removed from the function definition above. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel