From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 457DF1FF171 for ; Fri, 29 Nov 2024 14:26:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9819E19A68; Fri, 29 Nov 2024 14:26:17 +0100 (CET) Mime-Version: 1.0 Date: Fri, 29 Nov 2024 14:25:44 +0100 Message-Id: From: "Shannon Sterz" To: "Christian Ebner" , "Proxmox VE development discussion" X-Mailer: aerc 0.18.2-0-ge037c095a049-dirty References: <20241129124053.217032-1-c.ebner@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Nov 29, 2024 at 2:18 PM CET, Christian Ebner wrote: > On 11/29/24 14:09, Shannon Sterz wrote: > > On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: > >> Allow to select the change detection mode when performing manual > >> backups of containers with Proxmox Backup Server as target, just like > >> for the advanced backup job options introduced by commit 3b21f19f > >> ("www: advanced backup: add pbs change detection mode selector"). > >> > >> The selector is only shown in the backup window for containers and > >> only enabled when a Proxmox Backup Server is selected as target > >> storage. > >> > >> Link to issue in bugtracker: > >> https://bugzilla.proxmox.com/show_bug.cgi?id=5936 > >> > >> Signed-off-by: Christian Ebner > >> --- > >> www/manager6/window/Backup.js | 32 ++++++++++++++++++++++++++++++-- > >> 1 file changed, 30 insertions(+), 2 deletions(-) > >> > >> diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js > >> index 4418a9c7..82a2bd92 100644 > >> --- a/www/manager6/window/Backup.js > >> +++ b/www/manager6/window/Backup.js > >> @@ -53,6 +53,19 @@ Ext.define('PVE.window.Backup', { > >> }, > >> }); > >> > >> + let pbsChangeDetectionModeSelector = me.vmtype === 'lxc' ? Ext.create({ > >> + xtype: 'proxmoxKVComboBox', > >> + fieldLabel: gettext('PBS change detection mode'), > >> + name: 'pbs-change-detection-mode', > >> + deleteEmpty: true, > >> + value: '__default__', > >> + comboItems: [ > >> + ['__default__', "Default"], > >> + ['data', "Data"], > >> + ['metadata', "Metadata"], > >> + ], > >> + }) : null; > > > > nit: i think legibility of this would be improved by doing this instead: > > > > let pbsChangeDetectionModeSelector = null; > > if (me.vmtype === 'lxc') { > > pbsChangeDetectionModeSelector = Ext.create({ > > ... > > }) > > } > > > > it shouldn't be too much longer, but having a ternary operate span ten > > lines of code is a bit much :) > > Okay, another option would be to show the selector unconditionally for > both VMs and CTs, but only ever enable it for the CTs. > That way one could also get rid of the `vmtype` check when disabling the > selector below, and the window layout would remain the same for both > types, making it less messy and error prone for future adaptions. > > Opinions on that? i think that could be fine, as long as users have a way of knowing why the option is disabled. since it is never there for VMs regardless of the storage, it might be a little confusing. most other cases where we disable stuff like this it purely comes down to the storage's support for a feature afaict. maybe add "(Container Only)" to the field label? not sure if that works out layouting-wise though. "PBS change detection mode" is already pretty long (in the backup job's advanced section there is an extra explainer next to the field, which makes this clear). _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel