From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4E67B1FF183 for ; Fri, 29 Nov 2024 14:09:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DE0819420; Fri, 29 Nov 2024 14:09:37 +0100 (CET) Mime-Version: 1.0 Date: Fri, 29 Nov 2024 14:09:34 +0100 Message-Id: From: "Shannon Sterz" To: "Proxmox VE development discussion" X-Mailer: aerc 0.18.2-0-ge037c095a049-dirty References: <20241129124053.217032-1-c.ebner@proxmox.com> In-Reply-To: <20241129124053.217032-1-c.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: > Allow to select the change detection mode when performing manual > backups of containers with Proxmox Backup Server as target, just like > for the advanced backup job options introduced by commit 3b21f19f > ("www: advanced backup: add pbs change detection mode selector"). > > The selector is only shown in the backup window for containers and > only enabled when a Proxmox Backup Server is selected as target > storage. > > Link to issue in bugtracker: > https://bugzilla.proxmox.com/show_bug.cgi?id=5936 > > Signed-off-by: Christian Ebner > --- > www/manager6/window/Backup.js | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js > index 4418a9c7..82a2bd92 100644 > --- a/www/manager6/window/Backup.js > +++ b/www/manager6/window/Backup.js > @@ -53,6 +53,19 @@ Ext.define('PVE.window.Backup', { > }, > }); > > + let pbsChangeDetectionModeSelector = me.vmtype === 'lxc' ? Ext.create({ > + xtype: 'proxmoxKVComboBox', > + fieldLabel: gettext('PBS change detection mode'), > + name: 'pbs-change-detection-mode', > + deleteEmpty: true, > + value: '__default__', > + comboItems: [ > + ['__default__', "Default"], > + ['data', "Data"], > + ['metadata', "Metadata"], > + ], > + }) : null; nit: i think legibility of this would be improved by doing this instead: let pbsChangeDetectionModeSelector = null; if (me.vmtype === 'lxc') { pbsChangeDetectionModeSelector = Ext.create({ ... }) } it shouldn't be too much longer, but having a ternary operate span ten lines of code is a bit much :) > + > const keepNames = [ > ['keep-last', gettext('Keep Last')], > ['keep-hourly', gettext('Keep Hourly')], > @@ -110,10 +123,20 @@ Ext.define('PVE.window.Backup', { > if (rec && rec.data && rec.data.type === 'pbs') { > compressionSelector.setValue('zstd'); > compressionSelector.setDisabled(true); > - } else if (!compressionSelector.getEditable()) { > - compressionSelector.setDisabled(false); > + if (me.vmtype === 'lxc') { > + pbsChangeDetectionModeSelector.setValue('__default__'); > + pbsChangeDetectionModeSelector.setDisabled(false); > + } > + } else { > + if (!compressionSelector.getEditable()) { > + compressionSelector.setDisabled(false); > + } > + if (me.vmtype === 'lxc') { > + pbsChangeDetectionModeSelector.setDisabled(true); > + } > } > > + > Proxmox.Utils.API2Request({ > url: `/nodes/${me.nodename}/vzdump/defaults`, > method: 'GET', > @@ -193,6 +216,7 @@ Ext.define('PVE.window.Backup', { > storagesel, > modeSelector, > protectedCheckbox, > + pbsChangeDetectionModeSelector, > ], > column2: [ > compressionSelector, > @@ -289,6 +313,10 @@ Ext.define('PVE.window.Backup', { > params.protected = values.protected; > } > > + if (values['pbs-change-detection-mode']) { > + params['pbs-change-detection-mode'] = values['pbs-change-detection-mode']; > + } > + > if (values['notes-template']) { > params['notes-template'] = PVE.Utils.escapeNotesTemplate( > values['notes-template']); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel