From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4A6861FF168 for ; Tue, 26 Nov 2024 10:28:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78D5D2B1A7; Tue, 26 Nov 2024 10:28:29 +0100 (CET) Mime-Version: 1.0 Date: Tue, 26 Nov 2024 10:27:51 +0100 Message-Id: From: "Shannon Sterz" To: "Thomas Lamprecht" , "Proxmox VE development discussion" , "Lukas Wagner" X-Mailer: aerc 0.18.2-99-g1a3b2b24eb51-dirty References: <20240624123134.321417-1-l.wagner@proxmox.com> <0c825d39-69cc-49ce-a078-647818f6cc5a@proxmox.com> In-Reply-To: <0c825d39-69cc-49ce-a078-647818f6cc5a@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon Nov 25, 2024 at 11:19 PM CET, Thomas Lamprecht wrote: > Am 25.11.24 um 11:22 schrieb Lukas Wagner: >> Ping for patches 3-6, these were never applied. >> They do not add any functional changes, but only aim to improve >> code style and add some tests. >> > > > I applied them now, thanks! > > btw. I totally forgot to mention today that Shannon might need these sendmail > stuff too for the internal tooling she works on, so maybe making this public, > or moving it to a micro-crate could indeed be worth it. > Copying such small stuff more than once is most of the time a good signal that > it might be nonetheless good to share it; but no hard feelings either way from > my side, I just wanted to note that use case before I forget it. actually i needed to adapt this to add support for attachments, which require reworking the multipart logic a bit too. i can factor that out into it's own `proxmox-sendmail` crate or similar and make `proxmox-notify`'s sendmail endpoint use that too. if that's desired, i can send patches for that too. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel