From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id CF0B91FF163
for <inbox@lore.proxmox.com>; Thu, 21 Nov 2024 15:47:30 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 765D61FF53;
Thu, 21 Nov 2024 15:47:35 +0100 (CET)
Mime-Version: 1.0
Date: Thu, 21 Nov 2024 15:47:32 +0100
Message-Id: <D5RXTA3OPIVP.DFCWVRI9IYW8@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
X-Mailer: aerc 0.18.2-99-g1a3b2b24eb51-dirty
References: <20241121142809.332913-1-m.sandoval@proxmox.com>
In-Reply-To: <20241121142809.332913-1-m.sandoval@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.041 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [gnome.org]
Subject: Re: [pve-devel] [PATCH] webhook edit: do not split translatable
strings
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Thu Nov 21, 2024 at 3:28 PM CET, Maximiliano Sandoval wrote:
> Splitting translatable strings deprives translators for context which
> might be needed for getting the correct tenses or genders. See [1] for
> example.
>
> [1] https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(20)split(20)sentences.html
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/panel/WebhookEditPanel.js | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js
> index ca99333..9a7b222 100644
> --- a/src/panel/WebhookEditPanel.js
> +++ b/src/panel/WebhookEditPanel.js
> @@ -70,7 +70,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', {
> xtype: 'pmxWebhookKeyValueList',
> name: 'header',
> fieldLabel: gettext('Headers'),
> - subject: gettext('Header'),
> + addLabel: gettext('Add Header'),
> maskValues: false,
> cbind: {
> isCreate: '{isCreate}',
> @@ -92,7 +92,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', {
> xtype: 'pmxWebhookKeyValueList',
> name: 'secret',
> fieldLabel: gettext('Secrets'),
> - subject: gettext('Secret'),
> + addLabel: gettext('Add Secret'),
> maskValues: true,
> cbind: {
> isCreate: '{isCreate}',
> @@ -170,8 +170,8 @@ Ext.define('Proxmox.form.WebhookKeyValueList', {
> // override for column header
> fieldTitle: gettext('Item'),
>
> - // the text for a single element, used for the add button
> - subject: undefined,
> + // label displayed in the "Add" button
> + addLabel: undefined,
>
> // will be applied to the textfields
> maskRe: undefined,
> @@ -403,7 +403,7 @@ Ext.define('Proxmox.form.WebhookKeyValueList', {
> },
> {
> xtype: 'button',
> - text: me.subject ? Ext.String.format(gettext('Add {0}'), me.subject) : gettext('Add'),
> + text: me.addLabel ? me.addLabel : gettext('Add'),
wouldn't it be more elegant to simply define `addLabel` as
`gettext('Add')` and then override that where needed? that would safe
this akward ternary operator. haven't tested that though.
> iconCls: 'fa fa-plus-circle',
> handler: 'addLine',
> },
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel