From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 613891FF16B for ; Thu, 14 Nov 2024 09:37:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE68A2ADF7; Thu, 14 Nov 2024 09:37:36 +0100 (CET) Mime-Version: 1.0 Date: Thu, 14 Nov 2024 09:37:33 +0100 Message-Id: To: "Thomas Lamprecht" , "Proxmox VE development discussion" From: "Max Carrara" X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20241031170720.338794-1-m.carrara@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sectionconfig.pm, proxmox.com] Subject: Re: [pve-devel] partially-applied-series: [PATCH v3 pve-common 0/5] Section Config: Documentation & Code Cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon Nov 11, 2024 at 2:59 PM CET, Thomas Lamprecht wrote: > Am 31.10.24 um 18:07 schrieb Max Carrara: > > Section Config: Documentation & Code Cleanup - v3 > > ================================================= > > > > Notable Changes Since v2 > > ------------------------ > > > > * Adapt documentation syntax and style > > * Use less emphasis codes `I<>` > > * Add commit to fix spelling > > > > Please see the comments in the individual patches for a detailed list of > > changes. > > > > Older Versions > > -------------- > > > > v2: https://lore.proxmox.com/pve-devel/20240702141314.445130-1-m.carrara@proxmox.com/ > > v1: https://lore.proxmox.com/pve-devel/20240604092850.126083-1-m.carrara@proxmox.com/ > > > > Summary of Changes > > ------------------ > > > > Max Carrara (5): > > section config: document package and its methods with POD > > section config: update code style > > section config: clean up parser logic and semantics > > ^- skipped this one for now. > > > section config: make subroutine `delete_from_config` private > > section config: fix spelling of variable > > > > src/PVE/SectionConfig.pm | 1197 ++++++++++++++++++++++++++++++++------ > > 1 file changed, 1008 insertions(+), 189 deletions(-) > > > > After talking with Stefan Hanreich off-list he mentioned that this series was > helpfull to some recent section-config related work of his, so partially applied > this series, thanks! Thanks a bunch! Regarding the commit that was left out: I'll see if I can send this in as part of a separate series that perhaps also clears some other stuff up and adds some tests, since I'm in refactor-land at the moment anyway. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel