From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 012F41FF15C for ; Wed, 2 Oct 2024 09:50:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78CEEA09D; Wed, 2 Oct 2024 09:51:04 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 02 Oct 2024 09:50:31 +0200 Message-Id: From: "Shannon Sterz" To: "Proxmox VE development discussion" X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty References: <20241001140833.330843-1-m.sandoval@proxmox.com> In-Reply-To: <20241001140833.330843-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm] Subject: Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" note that the gui's default is a bit "fake". it pre-sets the field to `x86-64-v2-AES`, but if you click the little "x" next to it, the field will be cleared and if you submit the form like that the default ends up being `kvm64` again. this happens because the final config file does not specify a cpu type in this case and, hence, the old default is used for compatability reasons. so, this effectively removes the ability to set *no* cpu type via the cli if i'm not mistaken. might be worth considering. On Tue Oct 1, 2024 at 4:08 PM CEST, Maximiliano Sandoval wrote: > This makes it so newly created VMs, e.g. with `qm create` will have the > same default value as VMs created via the web UI. > > Signed-off-by: Maximiliano Sandoval > --- > I am not entirely sure if there is side-effect that I am not taking into account. > > PVE/API2/Qemu.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index d25a79fe..383218fd 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1152,6 +1152,10 @@ __PACKAGE__->register_method({ > $conf->{vmgenid} = PVE::QemuServer::generate_uuid(); > } > > + if (!defined($param->{cpu})) { > + $conf->{cpu} = 'x86-64-v2-AES'; > + } > + > my $machine_conf = PVE::QemuServer::Machine::parse_machine($conf->{machine}); > my $machine = $machine_conf->{type}; > if (!$machine || $machine =~ m/^(?:pc|q35|virt)$/) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel