From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9B99F1FF170 for ; Mon, 16 Sep 2024 13:13:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 068543EFD5; Mon, 16 Sep 2024 13:13:51 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 16 Sep 2024 13:13:16 +0200 Message-Id: To: "Proxmox VE development discussion" From: "Max Carrara" X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240702141314.445130-1-m.carrara@proxmox.com> In-Reply-To: <20240702141314.445130-1-m.carrara@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 pve-common 0/4] Section Config: Documentation & Code Cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Jul 2, 2024 at 4:13 PM CEST, Max Carrara wrote: > Section Config: Documentation & Code Cleanup - v2 > ================================================= Note for reviewers: This series will be superseded in the near future, so reviewing this isn't necessary at the moment. > > Notable Changes Since v1 > ------------------------ > > * Incorporate @Fabian's feedback regarding the docs [0] > * Reword commit message of patch 03 > * NEW: Patch 04: Make sub `delete_from_config` private > > Please see the comments in the individual patches for a detailed list of > changes. > > Older Versions > -------------- > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-June/064062.html > > References > ---------- > > [0]: https://lists.proxmox.com/pipermail/pve-devel/2024-June/064165.html > > Summary of Changes > ------------------ > > Max Carrara (4): > section config: document package and its methods with POD > section config: update code style > section config: clean up parser logic > section config: make subroutine `delete_from_config` private > > src/PVE/SectionConfig.pm | 1200 ++++++++++++++++++++++++++++++++------ > 1 file changed, 1015 insertions(+), 185 deletions(-) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel