From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8D50C1FF15E for ; Fri, 6 Sep 2024 14:15:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB1A911831; Fri, 6 Sep 2024 14:16:33 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 06 Sep 2024 14:16:00 +0200 Message-Id: From: "Alexander Zeidler" To: "Proxmox VE development discussion" References: <20240906104019.40450-1-f.ebner@proxmox.com> In-Reply-To: <20240906104019.40450-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Sep 6, 2024 at 12:40 PM CEST, Fiona Ebner wrote: > (DPkg::Pre-Invoke is also too late). Since this is just an additional > safety warning to guide new users, it should still be good enough. > + if ($line && $line =~ m/^CommandLine::AsString=apt(-get)?%20upgrade$/) { > + $log->("!! WARNING !!\n"); > + $log->("Using 'upgrade' can violate packaging assumptions made by Proxmox VE. Use 'dist-upgrade' instead.\n"); > + $log->("\n"); As "an additional safety warning to guide new users", we may want to rephrase this line: > + $log->("Press enter to continue, or C^c to abort.\n"); to something like: "Press CTRL+C to abort, or ENTER to continue anyway." _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel