From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 167821FF2AB
	for <inbox@lore.proxmox.com>; Wed, 17 Jul 2024 17:36:07 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 58DA23EA0A;
	Wed, 17 Jul 2024 17:36:36 +0200 (CEST)
Date: Wed, 17 Jul 2024 17:36:02 +0200
Message-Id: <D2RXB8G1KS2U.NZEBF4S3JQO2@proxmox.com>
To: "Proxmox Backup Server development discussion"
 <pbs-devel@lists.proxmox.com>, <pve-devel@lists.proxmox.com>
From: "Max Carrara" <m.carrara@proxmox.com>
Mime-Version: 1.0
X-Mailer: aerc 0.17.0-72-g6a84f1331f1c
References: <20240712112755.123630-1-l.wagner@proxmox.com>
 <20240712112755.123630-5-l.wagner@proxmox.com>
In-Reply-To: <20240712112755.123630-5-l.wagner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.029 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [pbs-devel] [PATCH proxmox-perl-rs v2 04/12]
 common: notify: add bindings for get_targets
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

And missed `cargo fmt` here too ;)

On Fri Jul 12, 2024 at 1:27 PM CEST, Lukas Wagner wrote:
> This allows us to drop the impl of that function on the perl side.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  common/src/notify.rs | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/common/src/notify.rs b/common/src/notify.rs
> index fe192d5..0f8a35d 100644
> --- a/common/src/notify.rs
> +++ b/common/src/notify.rs
> @@ -27,6 +27,7 @@ mod export {
>          MatcherConfigUpdater, SeverityMatcher,
>      };
>      use proxmox_notify::{api, Config, Notification, Severity};
> +    use proxmox_notify::api::Target;
>  
>      pub struct NotificationConfig {
>          config: Mutex<Config>,
> @@ -112,6 +113,14 @@ mod export {
>          api::common::send(&config, &notification)
>      }
>  
> +    #[export(serialize_error)]
> +    fn get_targets(
> +        #[try_from_ref] this: &NotificationConfig,
> +    ) -> Result<Vec<Target>, HttpError> {
> +        let config = this.config.lock().unwrap();
> +        api::get_targets(&config)
> +    }
> +
>      #[export(serialize_error)]
>      fn test_target(
>          #[try_from_ref] this: &NotificationConfig,



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel