From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E07281FF389 for ; Wed, 5 Jun 2024 10:57:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA3BA1EDC1; Wed, 5 Jun 2024 10:57:58 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 05 Jun 2024 10:57:56 +0200 Message-Id: From: "Shannon Sterz" To: "Daniel Krambrock" , X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty References: <20240522120553.49114-1-krambrock@hrz.uni-marburg.de> <20240522120553.49114-3-krambrock@hrz.uni-marburg.de> In-Reply-To: <20240522120553.49114-3-krambrock@hrz.uni-marburg.de> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH cluster] close #4369: make VMID suggestion strategy configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote: > Signed-off-by: Daniel Krambrock > --- > src/PVE/Cluster.pm | 1 + > src/PVE/DataCenterConfig.pm | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm > index f899dbe..059c7af 100644 > --- a/src/PVE/Cluster.pm > +++ b/src/PVE/Cluster.pm > @@ -84,6 +84,7 @@ my $observed = { > 'virtual-guest/profiles.cfg' => 1, > 'mapping/pci.cfg' => 1, > 'mapping/usb.cfg' => 1, > + 'used_vmids.list' => 1, > }; > > sub prepare_observed_file_basedirs { > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index abd0bbf..1394623 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -337,6 +337,15 @@ my $datacenter_schema = { > format => $next_id_format, > description => "Control the range for the free VMID auto-selection pool.", > }, > + 'next-id-strategy' => { > + optional => 1, > + type => 'string', > + enum => ['next-free', 'max+1', 'list'], > + default => 'next-free', > + description => "VMID allocation strategie. 'next-free' returns the lowerst free ID. " > + ."'max+1' returns the biggerst used ID + 1. " > + ."'list' returns the lowerst free ID that is not on the list of previously used IDs.", Nit: Some spell-checking - strategy, not strategie - lowest, not lowerst - biggest, not biggerst > + }, > migration => { > optional => 1, > type => 'string', format => $migration_format, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel