From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2921E1FF389 for <inbox@lore.proxmox.com>; Wed, 5 Jun 2024 10:56:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62C0D1ED03; Wed, 5 Jun 2024 10:56:52 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 05 Jun 2024 10:56:18 +0200 Message-Id: <D1RYIAHXBOIH.RM5K01KGND9T@proxmox.com> From: "Shannon Sterz" <s.sterz@proxmox.com> To: "Daniel Krambrock" <krambrock@hrz.uni-marburg.de>, <pve-devel@lists.proxmox.com> X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty References: <20240522120553.49114-1-krambrock@hrz.uni-marburg.de> In-Reply-To: <20240522120553.49114-1-krambrock@hrz.uni-marburg.de> X-SPAM-LEVEL: Spam detection results: 0 AWL -1.160 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ONLY_RE 2.2 Subject is only "Re:" KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] (no subject) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote: > This series of patches let the user choose a VMID suggestion strategy > to avoid the recycled VMID problem. Hi Daniel! Thanks for your contribution! First of some top-level feedback: - Please familiarize yourself with the Developer Documentation [1], Perl [2], and JavaScript [3] style guides before contributing. - Most importantly, if you haven't already, please contact `office@proxmox.com` about signing the Harmony CLA [4]. - All your patches provide the same git short message. Please provide more specific context for each patch and not just the the overall goal of your series. > Default is 'next-free', the previous strategy where the suggested VMID > is the lowest not used ID in range. This reuses VMIDs. > Added options are: > - 'max-1': selects the highest existing VMID and adds 1 I'm guessing you typo-ed the `max-1` here, as the other patches seem to correctly use `max+1`. Please note that such a strategy is still prone to re-use of IDs if one where to remove the VM with the highest ID. > - 'list': returns the lowest free VMID within the specified > range that is not on a list of previously used VMIDs > On guest deletion the VMID is added to '/etc/pve/used_vmids.list' Not sure if tracking the used VM/CT IDs in a separate file is the most elegant solution here. Especially as this is a somewhat niche usecase. Anyway, I'll provide some more detailed feedback in-line. Kind regards, Shannon PS: Please use "reply-all" when replying to me, so the full discussion stays on the mailing list. Thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel