From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8CD761FF394 for <inbox@lore.proxmox.com>; Mon, 3 Jun 2024 10:20:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CEAD81D318; Mon, 3 Jun 2024 10:20:39 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 03 Jun 2024 10:20:04 +0200 Message-Id: <D1Q8HGIPRB3E.1Y7V3RI109Z8X@proxmox.com> To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> From: "Max Carrara" <m.carrara@proxmox.com> X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240528081359.832986-1-c.heiss@proxmox.com> In-Reply-To: <20240528081359.832986-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer 0/7] use email regex from HTML spec for validation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Tue May 28, 2024 at 10:13 AM CEST, Christoph Heiss wrote: > This uses the regex for <input type="email" /> elements as defined in > the HTML spec to validate emails in the installer. That regex should be > a lot more robust than our current on and cover basically all cases of > email addresses that might be encountered in the while. > > Also, patch #6 adds validation for the auto-installer `global.mailto` > option too, while at it. > > Patches #1 through #4 are just small cleanups/fixes and may be applied > independently. > > [0] https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address The changes in this series are rather straightforward; there's nothing extraordinary going on. LGTM. Reviewed-by: Max Carrara <m.carrara@proxmox.com> > > Christoph Heiss (7): > cargo: convert `anyhow` to workspace dependency > tui: fix new clippy lint > auto-installer: drop some unneeded `pub` modifiers > auto-installer: print full anyhow message on failure > tui: use email regex from HTML specification for validation > auto-installer: validate `global.mailto` answer option > proxinstall: use email regex from HTML specification for validation > > Cargo.toml | 2 ++ > Proxmox/Makefile | 1 + > Proxmox/Sys.pm | 9 ++++++ > proxinstall | 3 +- > proxmox-auto-install-assistant/Cargo.toml | 2 +- > proxmox-auto-installer/Cargo.toml | 2 +- > .../src/bin/proxmox-auto-installer.rs | 2 +- > proxmox-auto-installer/src/utils.rs | 17 ++++++----- > proxmox-chroot/Cargo.toml | 2 +- > proxmox-fetch-answer/Cargo.toml | 2 +- > proxmox-installer-common/Cargo.toml | 1 + > proxmox-installer-common/src/options.rs | 29 ++++++++++++++++++- > proxmox-tui-installer/Cargo.toml | 1 - > proxmox-tui-installer/src/main.rs | 22 +++++--------- > 14 files changed, 65 insertions(+), 30 deletions(-) > create mode 100644 Proxmox/Sys.pm _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel