From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0E33B1FF37F for ; Thu, 18 Apr 2024 10:03:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A28E416658; Thu, 18 Apr 2024 10:03:07 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 18 Apr 2024 10:03:16 +0200 Message-Id: From: "Stefan Sterz" To: "Proxmox VE development discussion" X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty References: <20240418074406.22025-1-a.zeidler@proxmox.com> In-Reply-To: <20240418074406.22025-1-a.zeidler@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [n.sh] Subject: Re: [pve-devel] [PATCH manager] pve7to8: reword and fix typos in description X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu Apr 18, 2024 at 9:44 AM CEST, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidler > --- > bin/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/bin/Makefile b/bin/Makefile > index 180a91b5..aa149c06 100644 > --- a/bin/Makefile > +++ b/bin/Makefile > @@ -66,10 +66,10 @@ pve6to7.1: > > pve7to8.1: > printf ".TH PVE7TO8 1\n.SH NAME\npve7to8 \- Proxmox VE upgrade checker script for 7.4+ to current 8.x\n" > $@.tmp > - printf ".SH DESCRIPTION\nThis tool will help you to detect common pitfalls and misconfguration\ > - before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp > - printf "Any failure must be addressed before the upgrade, and any waring must be addressed, \ > - or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp > + printf ".SH DESCRIPTION\nThis tool will help you to detect common pitfalls and misconfiguration\ nit: the "to" in "to detect" is superfluous, "will help you detect" flows much nicer also, and this is a matter of personal style "misconfigurations" sounds better to me here because you stay in the plural, but that's really minor. > + before, and during the upgrade of a Proxmox VE system.\n" >> $@.tmp i know this is pre-existing, but since you are touching this anyway: the comma here is odd, if this was supposed to be an oxford comma (or serial comma), please be aware that these only apply in lists of three or more items. here we have two lists of two items, so the oxford comma does not apply. > + printf "Any failures or warnings must be addressed prior to the upgrade.\n" >> $@.tmp > + printf "If you think that a message is a false-positive, check this carefully before proceeding.\n" >> $@.tmp again a matter of personal taste, but "check this carefully" sounds a bit clumsy to me. maybe "double-check that the tool is incorrect before proceeding". > printf ".SH SYNOPSIS\npve7to8 [--full]\n" >> $@.tmp > mv $@.tmp $@ > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel