From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 31CF393E2F for ; Wed, 10 Apr 2024 09:52:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0959D98B1 for ; Wed, 10 Apr 2024 09:51:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Apr 2024 09:51:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E761F43648 for ; Wed, 10 Apr 2024 09:51:39 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 10 Apr 2024 09:51:39 +0200 Message-Id: From: "Stefan Sterz" To: "Stefan Sterz" , X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty References: <20231016162848.2546638-1-s.sterz@proxmox.com> In-Reply-To: <20231016162848.2546638-1-s.sterz@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2024 07:52:12 -0000 On Mon Oct 16, 2023 at 6:28 PM CEST, Stefan Sterz wrote: > some icons intentionally use black as their color in the light theme. > this includes the little pencil and check mark icon in the acme > overview. change their color to the regular dark-mode icon-color. for > this to work the filter inversion needed for some other icons needs to > be remove too. > > Signed-off-by: Stefan Sterz > --- > src/proxmox-dark/scss/other/_icons.scss | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/s= css/other/_icons.scss > index d4dc316..c045cf4 100644 > --- a/src/proxmox-dark/scss/other/_icons.scss > +++ b/src/proxmox-dark/scss/other/_icons.scss > @@ -104,6 +104,9 @@ > } > > // pbs show task log in longest task list column > +.fa.black, > +.fa.black::after, > +.fa.black::before, > .x-action-col-icon.fa-chevron-right::before { > filter: none; > } > @@ -222,6 +225,12 @@ > } > } > > +// set icon color of intentional black icons (e.g.: pencil icon for > +// quickly changing the ACME account) > +.fa.black { > + color: $icon-color; > +} > + > // The usage icons dynamically displaying how full a storage is > .usage-wrapper { > border: 1px solid $icon-color; > -- > 2.39.2 ping, this still applies for me :)