From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <m.carrara@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E7AECBA72B
for <pve-devel@lists.proxmox.com>; Wed, 20 Mar 2024 11:08:18 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C6ECEDD2C
for <pve-devel@lists.proxmox.com>; Wed, 20 Mar 2024 11:08:18 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 20 Mar 2024 11:08:18 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 165F648AF4
for <pve-devel@lists.proxmox.com>; Wed, 20 Mar 2024 11:08:18 +0100 (CET)
Content-Type: text/plain; charset=UTF-8
Date: Wed, 20 Mar 2024 11:08:17 +0100
Message-Id: <CZYHTGKUEHA8.HENU142PZOQA@proxmox.com>
From: "Max Carrara" <m.carrara@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, "Proxmox VE development
discussion" <pve-devel@lists.proxmox.com>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Mailer: aerc 0.17.0-72-g6a84f1331f1c
References: <20240319153250.629369-1-m.carrara@proxmox.com>
<20240319153250.629369-5-m.carrara@proxmox.com>
<2d4dd320-e143-4802-8bfd-dc9f0f921319@proxmox.com>
In-Reply-To: <2d4dd320-e143-4802-8bfd-dc9f0f921319@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.026 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] listvms: add
arg parser, context manager for connections, fetch helper
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2024 10:08:19 -0000
On Wed Mar 20, 2024 at 10:39 AM CET, Lukas Wagner wrote:
>
>
> On 2024-03-19 16:32, Max Carrara wrote:
>
> > + def _squeeze_and_wrap(text: str) -> str:
> > + """Makes it easier to write help text using multiline strings.=
"""
> > +
> > + text =3D text.replace("\n", " ").strip()
> > +
> > + # squeeze recurring spaces
> > + while " " in text:
> > + text =3D text.replace(" ", " ")
> > +
>
> How about `" ".join(text.split())`? :)
That would indeed also work here - I tend to automatically resort to the
while-loop because `str.split()` also splits on `\n`, `\t` and some
other whitespace characters, which is what I *usually* want to avoid,
but in this case it's unnecessary.
Will use your suggestion instead in v2, thanks!