From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2DEA2B96C5 for ; Thu, 14 Mar 2024 15:44:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06D2AF37C for ; Thu, 14 Mar 2024 15:44:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Mar 2024 15:43:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2860A489D3 for ; Thu, 14 Mar 2024 15:43:59 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 14 Mar 2024 15:43:58 +0100 Message-Id: From: "Stefan Sterz" To: "Proxmox VE development discussion" X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty References: <20240313084401.46297-1-f.weber@proxmox.com> In-Reply-To: <20240313084401.46297-1-f.weber@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] ui: pool members: avoid setting request parameter for all edit windows X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2024 14:44:30 -0000 On Wed Mar 13, 2024 at 9:44 AM CET, Friedrich Weber wrote: > Currently, after adding a storage to a pool, opening any edit window > will send a GET request with a superfluous `poolid` parameter and > cause a parameter verification error in the GUI. This breaks all edit > windows of the current session. A workaround is to reload the current > browser session. > > This happens because the `PVE.pool.AddStorage` component inadvertently > adds `poolid` to an `extraRequestParams` object that is shared by all > instances of `Proxmox.window.Edit`, affecting all edit windows in the > current session. Fix this by instead creating a new object that is > local to the component. > > Fixes: cd731902b7a724b1ab747276f9c6343734f1d8cb > Signed-off-by: Friedrich Weber > --- > > Notes: > To check if we have this problem at other places, I did a quick searc= h > for `extraRequestParams` in PVE+PBS: Seems like for all other usages, > the object is created fresh already. > > www/manager6/grid/PoolMembers.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMem= bers.js > index 75f20cab..61e27dff 100644 > --- a/www/manager6/grid/PoolMembers.js > +++ b/www/manager6/grid/PoolMembers.js > @@ -123,7 +123,7 @@ Ext.define('PVE.pool.AddStorage', { > me.isAdd =3D true; > me.url =3D "/pools/"; > me.method =3D 'PUT'; > - me.extraRequestParams.poolid =3D me.pool; > + me.extraRequestParams =3D { 'poolid': me.pool }; note that you don't need to quote `poolid` here as it doesn't contain hyphens as such. quickly grepping over our codebase it seems that not quoting keys is preferred if it isn't needed > > Ext.apply(me, { > subject: gettext('Storage'),