From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <h.laimer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id D5A0194DB4
for <pve-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:59:34 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BDDAD17E51
for <pve-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:59:34 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:59:33 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8B6AB44F15
for <pve-devel@lists.proxmox.com>; Fri, 23 Feb 2024 12:59:33 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 23 Feb 2024 12:59:32 +0100
Message-Id: <CZCFWHAY48JH.34JNGWURMQP7B@dev>
From: "Hannes Laimer" <h.laimer@proxmox.com>
To: "Aaron Lauterer" <a.lauterer@proxmox.com>, "Proxmox VE development
discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.14.0
References: <20240223114551.15392-1-h.laimer@proxmox.com>
<df7ea7c3-ddc9-4fc0-91a2-d18e7eaa5435@proxmox.com>
In-Reply-To: <df7ea7c3-ddc9-4fc0-91a2-d18e7eaa5435@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.007 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint
checkmark to directory storage edit
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 23 Feb 2024 11:59:34 -0000
On Fri Feb 23, 2024 at 12:51 PM CET, Aaron Lauterer wrote:
> Overall good idea :)
>
> On 2/23/24 12:45, Hannes Laimer wrote:
> > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> > ---
> >=20
> > came up in enterprise support, and I don't think there is a reason to
> > not have it in the UI, while having it in the API
> >=20
> > www/manager6/storage/DirEdit.js | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >=20
> > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/Dir=
Edit.js
> > index 3e2025fc..52e7134b 100644
> > --- a/www/manager6/storage/DirEdit.js
> > +++ b/www/manager6/storage/DirEdit.js
> > @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
> > },
> > ];
> > =20
> > + me.advancedColumn2 =3D [
> > + {
> > + xtype: 'proxmoxcheckbox',
> > + name: 'is_mountpoint',
> > + uncheckedValue: 0,
> > + fieldLabel: gettext('Mountpoint'),
> > + autoEl: {
> > + tag: 'div',
> > + 'data-qtip': gettext('Enable if something is mounted to this dir=
ectory externally, storage is considered offline as long as nothing is moun=
ted.'),
>
> Maybe phrase the tooltip like this?
>
> Enable if something is mounted at this path. Storage is considered offlin=
e as long as nothing is mounted.
sure, I'll send a v2
>
>
> As there are also use-cases where something local is mounted outside of t=
he PVE tooling where the is_mountpoint option is useful.
>
> > + },
> > + },
> > + ];
> > me.callParent();
> > },
> > });