From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9E2419830A for ; Fri, 6 Oct 2023 16:41:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 855D52B41 for ; Fri, 6 Oct 2023 16:41:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 6 Oct 2023 16:41:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9100C43EFA for ; Fri, 6 Oct 2023 16:41:10 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Oct 2023 16:41:09 +0200 From: "Stefan Sterz" To: "Lukas Wagner" , "Proxmox VE development discussion" , "Philipp Hufnagl" Message-Id: X-Mailer: aerc 0.14.0 References: <20230922143658.1639173-1-p.hufnagl@proxmox.com> <20230922143658.1639173-4-p.hufnagl@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2023 14:41:44 -0000 On Fri Oct 6, 2023 at 3:16 PM CEST, Lukas Wagner wrote: -- snip 8< -- > > +$background-hint: hsl(233deg, 99%, 60%); > > That particular color tone looks pretty out of place to me in dark mode. > In light mode, you use the same hue as other interface elements, is > there a reason why you use a different color in dark mode? > > Playing around a bit, hsl(205, 100%, 40%) or hsl(205, 100%, 45%) would > look about right for me, that's the same hue as other elements, > while being a bit toned down (reduced lightness). > > @sterzy, maybe you can provide some feedback as well? > > Also, small bug: the hint-color seems to disappear when the 'expiry' > is clicked, only seems to affect dark mode. in general: please refrain from defining new colors. you are very likely not the first person that needs to highlight something in a row. in this case: why not use either `$primary-dark` if it needs to be blue. or in my opinion: use `$background-warning`. this would be semantically fitting as you want to warn an admin that this user is about to expire. for the light theme you could simply use the `.warning` class instead then you can simply overwrite that with a more specific selector in the dark theme again, like we already do in a couple of places. defining new colors each time you want to highlight something in the ui quikly leads to a visual mess, instead try to re-use colors that already have some kind of semantic meaning. this will make it easier to visually parse the ui quikly. -- snip 8< --