From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AFEBB982D0 for ; Fri, 6 Oct 2023 16:42:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7A57B2B65 for ; Fri, 6 Oct 2023 16:41:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 6 Oct 2023 16:41:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A307A43F99 for ; Fri, 6 Oct 2023 16:41:46 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Oct 2023 16:41:46 +0200 From: "Stefan Sterz" To: "Proxmox VE development discussion" Message-Id: X-Mailer: aerc 0.14.0 References: <20230922143658.1639173-1-p.hufnagl@proxmox.com> <20230922143658.1639173-5-p.hufnagl@proxmox.com> In-Reply-To: <20230922143658.1639173-5-p.hufnagl@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2023 14:42:17 -0000 On Fri Sep 22, 2023 at 4:36 PM CEST, Philipp Hufnagl wrote: -- snip 8< -- > +$text-color-warning: hsl(48deg, 100%, 50%); > > // Borders > $border-color: hsl(0deg, 0%, 40%); > diff --git a/src/proxmox-dark/scss/extjs/_menu.scss b/src/proxmox-dark/sc= ss/extjs/_menu.scss > index 2983f60..aa51260 100644 > --- a/src/proxmox-dark/scss/extjs/_menu.scss > +++ b/src/proxmox-dark/scss/extjs/_menu.scss > @@ -33,6 +33,10 @@ > color: $icon-color; > } > > +.x-menu-item-icon-default.warning { > + color: $text-color-warning; > +} > + same here, please don't define new colors unless you must. in this case there is an argument to be made that this needs to be a new color as we don't have a text color for warnings. except, we kind of do: gauges use a brigther version of the warning and invalid background colors. please factor these out into their own variables and use those here and in `src/proxmox-dark/scss/_charts.scss`, which is where we curretnly define the brigther colors. -- snip 8< --