From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 05FACB8D8 for ; Tue, 12 Sep 2023 14:18:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D500F12B80 for ; Tue, 12 Sep 2023 14:18:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Sep 2023 14:18:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A273C45F63 for ; Tue, 12 Sep 2023 14:18:20 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 Sep 2023 14:18:19 +0200 To: "Proxmox VE development discussion" From: "Stefan Sterz" Message-Id: X-Mailer: aerc 0.14.0 References: <20230912093148.29060-1-f.ebner@proxmox.com> In-Reply-To: <20230912093148.29060-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH pve-zsync] parse disks: improve error messages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2023 12:18:52 -0000 On Tue Sep 12, 2023 at 11:31 AM CEST, Fiona Ebner wrote: > The one with the backup flag was reported in the community forum: > https://forum.proxmox.com/threads/77254/ > > Signed-off-by: Fiona Ebner > --- > pve-zsync | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/pve-zsync b/pve-zsync > index 98190b2..0e48865 100755 > --- a/pve-zsync > +++ b/pve-zsync > @@ -949,11 +949,12 @@ sub parse_disks { > $num++; > > } else { > - die "ERROR: in path\n"; > + die "unexpected path '$path'\n"; > } > } > > - die "Vm include no disk on zfs.\n" if !$disks->{0}; > + die "guest does not include any ZFS volumes (or all excluded by the = backup flag).\n" small nit: "guest" should be capitalized if this is the beginning of a sentence. and imo "all are excluded" sounds more proper. > + if !$disks->{0}; > return $disks; > } > > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel