From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 335ED88AA for ; Fri, 28 Jul 2023 10:37:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06B1A13272 for ; Fri, 28 Jul 2023 10:37:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 28 Jul 2023 10:37:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5C61741E3A for ; Fri, 28 Jul 2023 10:37:13 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 28 Jul 2023 10:37:12 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox VE development discussion" , X-Mailer: aerc 0.14.0 References: <20230727133341.1009881-1-c.heiss@proxmox.com> <20230727133341.1009881-3-c.heiss@proxmox.com> In-Reply-To: <20230727133341.1009881-3-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2023 08:37:14 -0000 On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote: > The checkbox is enabled by default for new realms, setting the new > `check-connection` parameter. > > Won't effect existing configurations, i.e. being opt-in for them, to not > break existing setups. As mentioned in my other reply, I think setting the new parameter by defaul= t should not be a problem, as long as it is only in the GUI. > > --- a/www/manager6/dc/AuthEditLDAP.js > +++ b/www/manager6/dc/AuthEditLDAP.js > @@ -79,6 +79,21 @@ Ext.define('PVE.panel.LDAPInputPanel', { > }, > ]; > > + me.advancedItems =3D [ > + { > + xtype: 'proxmoxcheckbox', > + fieldLabel: gettext('Check connection'), > + name: 'check-connection', > + uncheckedValue: 0, > + checked: me.isCreate, > + autoEl: { > + tag: 'div', > + 'data-qtip': > + gettext('Verify connection parameters and bind credentials on save'), > + }, > + }, > + ]; > + > me.callParent(); > }, > onGetValues: function(values) { AD realms have their own GUI component, so I guess it would also make sense= to add the new parameter there.