From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2EC1A75053 for ; Wed, 21 Apr 2021 03:38:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1422094EC for ; Wed, 21 Apr 2021 03:37:30 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4D5D794D4 for ; Wed, 21 Apr 2021 03:37:26 +0200 (CEST) Received: by mail-ej1-x62b.google.com with SMTP id l4so61045365ejc.10 for ; Tue, 20 Apr 2021 18:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o03Mc26gaCnYn/jdZWktD7O51FxjWBkbKTUFFIuN/ME=; b=Ql/nGrX/j1VoYlDEZkZPaYce68oSl+dFWKicghh3ma0KB2znP85IH/GLSUDYIkdoDp ZkQ0sGodKzO8klFBa8IrZmGo/7ydHtEwjcZk81dAv6OmqATZcvOVj75+vgllGCFBSn8y n3m5n3Gseuld3bLKiN0xZjscpHLf+qm9gd7YlbwkSrgrtFqlvJjS3QGMnSQK0uUemIoF q2oofCUU4PH1TBI4kq9R3JaHUpX4hC9Me6AsiCFpjpzFF8Fndz2wk2MCXNF7NT+ifnJz XWJTtiiMmtHSqCiWsV9avuQ8QwC0R9wMqnQPrrhbeiY9r2m7Z+orK2UulRyTo1/5lO60 SzAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o03Mc26gaCnYn/jdZWktD7O51FxjWBkbKTUFFIuN/ME=; b=eufo8QIazTf+P73NtDWCsd4sGMn2+aV4LUw2cddQqHoC/KHNJDy/7u7TmK6/KNjNpn ZoQ3DnsDkIATlt9dfJwKhBZ3D8itOEjk1n7Za0cDhgdpRjcINSve3+keJwMw5Ub+I1JC tgpPFdYAcVS6j9xAQphjVCMz49/PmEzSp3Qf0oxi8eSgxWxRoifEK50zcmpaM2loTMns wjbONLoXw1C2wpsqNIN7czJEiTjbiUiRDBPb1tI6sVS3AxIV8rsR/FFK9O9cCUe1Mw/h Vvd/3238xyKjtvOazcGcWTI/+xEd3BFRPvJ74OAQFEUTInk8RkQxK2mB/SmAG1u0Z0Za uQyQ== X-Gm-Message-State: AOAM533PIfDHDk6iOBndwy/qF/3qRM8fxLdahSJ0U9avhSYu6gVNCULa ljB0u3VP5U6sE8eMd5bnO2+NPut1TRXVxEN4j/x9dQ2ZbF8lnw== X-Google-Smtp-Source: ABdhPJyXk7I/u7I1o+esEzyqpzoVD4O6+977UWiyevbVIUishcHP1t7sZqMaHr3MOnyDN6TKAGINJa2WmED+k3zNgCM= X-Received: by 2002:a17:906:d213:: with SMTP id w19mr5797437ejz.16.1618969039864; Tue, 20 Apr 2021 18:37:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bruce Wainer Date: Tue, 20 Apr 2021 21:37:08 -0400 Message-ID: To: Dominik Csapak Cc: Proxmox VE development discussion X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [pve-manager] Adding real disk usage information (discussion) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 01:38:00 -0000 Dominik, Thank you for the insight. There is certainly complexity I did not consider, even if I were to look at the narrow case of local ZFS storage. Regardless, this would be helpful to me and if I make anything then I will submit it. I already have signed the CLA and have code accepted in pve-zsync. Thank you, Bruce On Mon, Apr 19, 2021 at 2:55 AM Dominik Csapak wrote: > On 4/16/21 22:18, Bruce Wainer wrote: > > Hello, > > > > Hi, > > > I am interested in seeing real disk usage information for VM Disks and CT > > Volumes, on storage types that have thin provisioning and/or snapshots. > > Specifically I would like to see "Current Disk Usage (Thin)" and either > > "Snapshot Usage" or "Total Disk Usage". I only use local ZFS on servers > at > > this time, but I'm sure the GUI side would be best made flexible. > > while this sounds sensible, this will get hard very fast. > For example, take a LVM-Thin storage. > > I have a template which has an LV which uses some space. > This can have X linked clones, where each clone can have Y snapshots. > > since lvmthin lvs/snapshots/etc. are only very loosely coupled. > It is very hard to attribute the correct number to any > of those vms/templates. (e.g. do you want to calculate the > template storage again for each vm? only once? what if > you cloned a vm from a snapshot?) > > It gets even harder on storage that can deduplicate (e.g. ZFS) or > where the 'real' usage is dynamically inflated by some form of replica > (e.g. Ceph). > > So, while this sounds nice, and we would probably not oppose a clean > solution, this is not a trivial problem to solve. > > > > > Is someone interested in helping with this? Where would I start, > especially > > on the GUI part, if I were to develop this myself? > > anyway, to answer this question, the storage plugins in the backend can > be found in the pve-storage git repo[0] > > the point where the status api calls of the vms/cts are called live > in qemu-server[1] and pve-container[2] respectively > (the api part is in PVE/API2/) > > you can find the gui part in pve-manger[3] in www/manager6 > > also if you want to send patches, please read the developer > documentation [4] especially the bit about the CLA > > if you have any more question, please ask :) > > hope this helps > kind regards > > 0: > > https://git.proxmox.com/?p=pve-storage.git;a=tree;f=PVE/Storage;h=fd53af5e74407deda65785b164fb61a4f644a6e0;hb=refs/heads/master > 1: https://git.proxmox.com/?p=qemu-server.git;a=summary > 2: https://git.proxmox.com/?p=pve-container.git;a=summary > 3: > > https://git.proxmox.com/?p=pve-manager.git;a=tree;f=www/manager6;hb=refs/heads/master > 4: https://pve.proxmox.com/wiki/Developer_Documentation > > > > > Thank you, > > Bruce Wainer > > _______________________________________________ > > pve-devel mailing list > > pve-devel@lists.proxmox.com > > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > > > > >