From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 08A6862622 for ; Mon, 26 Oct 2020 08:56:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6F88E24F for ; Mon, 26 Oct 2020 08:56:01 +0100 (CET) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A7DBCE242 for ; Mon, 26 Oct 2020 08:55:58 +0100 (CET) Received: by mail-lf1-x134.google.com with SMTP id a7so10511609lfk.9 for ; Mon, 26 Oct 2020 00:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eDuw30GsWdirq8MKwqVG0le5wPOtr93vx42N3Zo6A8c=; b=zdsu/y/SL0yAXqlSLhRZHJbZrA5vYuu+w6GVATtrH/OV4T7GfzAXzEZvQr/j5XNRBs Sg+uyGM4+VCaoEAgO7C+0ZtftmtU4UKHvfNQedJ0uQ1SV/sAiitrqJ0QL+5lCMRLbP8y LPZA1J1L/gJdXe8/MX9f1ZsKOZb+uiWtB8SEfnYGmENuOLVL8tvgmXTzgV8fP2wNfJ9w HpRrHzyeF6YBOR4qH253qjIMp5soM+/kH46cOHmVofqxJbF5zkmy22n0oOyXrhHJLMsS wNtfIl9v3YGUU85BTqzt8qGXJJlwMmYtkHTUW/ogoaRMZBtXdo6BjqJ9YjEydDjM0fbu G6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eDuw30GsWdirq8MKwqVG0le5wPOtr93vx42N3Zo6A8c=; b=allzxLWAya1gpTeyNW4g1bhX57BecHSzCoXmLP6gLoE8CFNhfu7hrhwySnj4U/XkHU PERP2VWSCe9+Cp0c5gdtP2U7zn3TklPPDgyonm4x8E47vFEaPLMmJsVKcG18HLtzndJG 6IyyPHwm4HO2EAp9LAjz2RSszN2DJhOiJAkvFnWIjHJLRO1zbu93i6erxugOvUrkncGg cwZp/+LXrcRzNvVsJ3GxVSS7hm6sMLPADMfqUjELW2MzeQmYkerAHGMBqKqhXd1GxqNn 6FPwT4uvF1E7yK/EczjBDQkaQKgetCdAwzuHwunVnQu/3IbOOUCW/x6Se3HvXD03tV4N DORg== X-Gm-Message-State: AOAM532rqTjXOKOLgtBXN5XDrLUQyoPRH85AdsBlVRzyX7cSE+6enyO4 sGaoS9/OCuVsidAWG2oLY65OBVrwoYvfzgFckwifIg== X-Google-Smtp-Source: ABdhPJzrzVvW3is8BuRbhsa1E2P73ZVISX/5ncTMH09/c6FeWXpLx3VOxb/4jRAS6uDVTbVHQ0z/uauNPz+VyT4TU7M= X-Received: by 2002:a19:5e5c:: with SMTP id z28mr4398049lfi.528.1603698951955; Mon, 26 Oct 2020 00:55:51 -0700 (PDT) MIME-Version: 1.0 References: <20201006115850.1026534-1-aderumier@odiso.com> <589366911.632.1602568628596@webmail.proxmox.com> <192891807.455.1603439430434@webmail.proxmox.com> In-Reply-To: From: Alexandre Derumier Date: Mon, 26 Oct 2020 08:55:40 +0100 Message-ID: To: Thomas Lamprecht Cc: Proxmox VE development discussion , Dietmar Maurer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager] pvestatd: stream host pressure counters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 07:56:32 -0000 >>that'd drop all old statistics, and be a bit of a nuisance to upgrade ins= ide >>a cluster (old nodes get stuff they do not comprehend). oh ok, I thinked that rrd was able to add new value. (don't have used rrd since a long time since I'm using influxdb or other metrics databases) I'll look to add them in separated rrd files Le sam. 24 oct. 2020 =C3=A0 17:43, Thomas Lamprecht a =C3=A9crit : > > On 24.10.20 15:46, Alexandre Derumier wrote: > >> Sounds reasonable. We just need to find a way to add new values > >> in a compatible way. > > > > Last time in 2013, we had added a new rrd "pve2.3-vm/" > > https://lists.proxmox.com/pipermail/pve-devel/2013-January/005612.html > > that'd drop all old statistics, and be a bit of a nuisance to upgrade ins= ide > a cluster (old nodes get stuff they do not comprehend). > > We may rather want to have a new, separate, file for this. > We could add general support for and error handling now, and to the final= add > with 7.0 next year or so. Maybe there's even a way to add it now without = other > nodes producing errors, but from top of my head I am not sure.. > > In Proxmox Backup Server we have each metric in a separate file, makes it= a bit > easier to extend on. > > # ls -l /var/lib/proxmox-backup/rrdb/host/ > total 160 > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 cpu > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 io_ticks > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 iowait > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 loadavg > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 memtotal > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 memused > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 netin > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 netout > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 read_bytes > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 read_ios > -rw-r--r-- 1 backup backup 6008 Jun 4 18:03 read_ticks > -rw-r--r-- 1 backup backup 6008 May 28 13:00 roottotal > -rw-r--r-- 1 backup backup 6008 May 28 13:00 rootused > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 swaptotal > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 swapused > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 total > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 used > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 write_bytes > -rw-r--r-- 1 backup backup 6008 Oct 23 07:45 write_ios > -rw-r--r-- 1 backup backup 6008 Jun 4 18:03 write_ticks > > > We could say we keep the base stuff as is in a single file and add > the new one with a "." scheme. > >