From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3027F69D2A for ; Mon, 16 Nov 2020 07:39:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6CDC2ABB1 for ; Mon, 16 Nov 2020 07:38:31 +0100 (CET) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8B8D32ABA7 for ; Mon, 16 Nov 2020 07:38:26 +0100 (CET) Received: by mail-lj1-x243.google.com with SMTP id b17so18829957ljf.12 for ; Sun, 15 Nov 2020 22:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=IV8uElgta0QKIWw6+DTfYzLhsYc2CD7Va9y7cBlIsyI=; b=IQXQevqBDDvdZ/1taJ7i/LTe24el6TLvaktQiBfsKVC9RjcYJT1FQs+nW9xQT6f6TM y1hU5Q8ebYz8IBCbOIqo55zAMbNkYHL7obgHJeMXr4MJ/GtIYQJhCE/3Mb8LGqttjVKn q2QsenrLwF9oTMDGYXaq8OZycoO/CIqVZJRkt1I5O1r5O5CT72SJSldg42M3gdI7Rt0M buCaUgqOCdRLjBJTCBG0XhlnTif6iKXkBkB5WkDJz7QGPzN1rQR2Zop60rMLp+MEuVdb TJvW/xvIK6kQkoqneXcLgW9nW3mrPGpYW9EQjr6eY5+1hkKQIpv02Rd/zXcYsL4lDoHf l1vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=IV8uElgta0QKIWw6+DTfYzLhsYc2CD7Va9y7cBlIsyI=; b=A3vUufzPBec9898L9SXKfCyTBE/V0JHb0+PWpraetLYrpdvnY/MUdEqkxesuns6Mwa aBuJblJu8JERBsV+MelOVTuB1x/nHHSVp4Ocmm63TfCIgI6ryEgWcb/7f9UVLij1I5lo vqb0aMocot6zhst0bE+tuundFWbgg/CcfPpiqXI6zM9fouG0ifZrS8bLeLfItzeGBn7T MnaAaHGn6AtIc2bWOyuE81Q8cK/O5F3cPWvuFkp3ErsvqV4C+sYUgSqfam6UZuV+Pd6N KAYt8VOfuskoyxdlemBCq0VqRdJP2QPN4HSzKNtLCseuMGUPuckkNX4nUcN6Fa13FkvX DMoA== X-Gm-Message-State: AOAM531As3WJeMz7RYrKOCUToMJh6J/PE+UF9XCGTJQJS55yp1Wxm9AD X8DZq33I59/sUUQGRIY/5g9qgV6srPxKPdfqCB/T8Bdp10oHDg== X-Google-Smtp-Source: ABdhPJzyGf+AwuQY6/t5FYv0dq8C02EZqLT1N3YLXvCznUKxjuHf4L1ApaSjaOyyF8y5sf9CelEOW4ndxqkgPiBkpNs= X-Received: by 2002:a2e:9b83:: with SMTP id z3mr5408950lji.145.1605508699486; Sun, 15 Nov 2020 22:38:19 -0800 (PST) MIME-Version: 1.0 References: <20201115183609.3022395-1-aderumier@odiso.com> In-Reply-To: <20201115183609.3022395-1-aderumier@odiso.com> From: Alexandre Derumier Date: Mon, 16 Nov 2020 07:38:08 +0100 Message-ID: To: Proxmox VE development discussion Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.142 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH pve-kernel] add patch: vhost: bump max_mem_regions to 509 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2020 06:39:02 -0000 BTW, maybe as futur improvement, we could add an option to specify static dimm size. (like all dimm are 2GB, 4GB,...) Should be easy to implement, and only change increment in gui for maxmem,balloon. (I'm also looking to implement virtio-mem, but I think it's not 100% complete for unplug currently) Le dim. 15 nov. 2020 =C3=A0 19:36, Alexandre Derumier = a =C3=A9crit : > > Currently, default value is 64, so qemu is limited to 64 hotplug dimm > > original patch from 2015 > https://patchwork.kernel.org/project/kvm/patch/1438180163-275465-3-git-se= nd-email-imammedo@redhat.com/ > > We have discusted about this in 2016 (At this time some optimisations pat= ches were missing) > https://lists.proxmox.com/pipermail/pve-devel/2016-December/024502.html > > Also, this fix this bugzilla > https://bugzilla.proxmox.com/show_bug.cgi?id=3D1426 > > Wolfgang proposed to have explicit dimm module management, it could be gr= eat, > but for now this patch is fixed the current implemlentation. > > > > Signed-off-by: Alexandre Derumier > --- > ...08-vhost-bump-max_mem_regions-to-509.patch | 32 +++++++++++++++++++ > submodules/ubuntu-focal | 2 +- > 2 files changed, 33 insertions(+), 1 deletion(-) > create mode 100644 patches/kernel/0008-vhost-bump-max_mem_regions-to-509= .patch > > diff --git a/patches/kernel/0008-vhost-bump-max_mem_regions-to-509.patch = b/patches/kernel/0008-vhost-bump-max_mem_regions-to-509.patch > new file mode 100644 > index 0000000..f547b7d > --- /dev/null > +++ b/patches/kernel/0008-vhost-bump-max_mem_regions-to-509.patch > @@ -0,0 +1,32 @@ > +From 721ac248403a4c7ea98c416fc28f22c0bfbbb63d Mon Sep 17 00:00:00 2001 > +From: Alexandre Derumier > +Date: Sun, 15 Nov 2020 19:19:28 +0100 > +Subject: [PATCH] vhost: bump max_mem_regions to 509 > + > +Currently, default value is 64, so qemu is limited to 64 hotplug dimm > + > +Signed-off-by: Alexandre Derumier > +--- > + drivers/vhost/vhost.c | 4 ++-- > + 1 file changed, 2 insertions(+), 2 deletions(-) > + > +diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > +index 36ca2cf419bf..1d3eae6555fa 100644 > +--- a/drivers/vhost/vhost.c > ++++ b/drivers/vhost/vhost.c > +@@ -33,10 +33,10 @@ > + > + #include "vhost.h" > + > +-static ushort max_mem_regions =3D 64; > ++static ushort max_mem_regions =3D 509; > + module_param(max_mem_regions, ushort, 0444); > + MODULE_PARM_DESC(max_mem_regions, > +- "Maximum number of memory regions in memory map. (default: 64)"); > ++ "Maximum number of memory regions in memory map. (default: 509)")= ; > + static int max_iotlb_entries =3D 2048; > + module_param(max_iotlb_entries, int, 0444); > + MODULE_PARM_DESC(max_iotlb_entries, > +-- > +2.20.1 > + > diff --git a/submodules/ubuntu-focal b/submodules/ubuntu-focal > index fd386a6..721ac24 160000 > --- a/submodules/ubuntu-focal > +++ b/submodules/ubuntu-focal > @@ -1 +1 @@ > -Subproject commit fd386a64a1ed3f2f047318508ebd733f56a4fab2 > +Subproject commit 721ac248403a4c7ea98c416fc28f22c0bfbbb63d > -- > 2.20.1 >