From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A95C60587 for ; Tue, 17 Nov 2020 11:54:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 00809EA9A for ; Tue, 17 Nov 2020 11:54:19 +0100 (CET) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 350BCEA8E for ; Tue, 17 Nov 2020 11:54:17 +0100 (CET) Received: by mail-lj1-x241.google.com with SMTP id y16so23759569ljh.0 for ; Tue, 17 Nov 2020 02:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Qu8NO+F9VWAb9WRbxQxMcyFrqTng8BTuMlEBgIsSRnM=; b=z0UNzbwarInAXgzwLIvG0AZHC+G4al8MVabcqn5NyElkSJGcw6GoskVvZZIs5uWV8n v4dWI8c+M5mfIQKv9jEzflc/fWgCq7kJYinC9rIQg+AlsxpKp8QRJawa5g3ooCDGFps2 /QSsFv3Nk03tchHZJzirjQNJl9X5xwOi/XlQcRFHCKy988FgEl2HdxNFWEgS7xPbMLdb t1Dl1aTQ3g9Qjd5Dm/nwQaNdal7POIhJjoEAs3ExFo2IfSdcitONDCfYYPJufiRr7m6O o0/xFe2+M2mUC+qivksVOkgDI5PGiwGcyrEyjaSJoB2rpcjJLeShfL7sUAEtrZo283ND V3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Qu8NO+F9VWAb9WRbxQxMcyFrqTng8BTuMlEBgIsSRnM=; b=rTL53EGbtsOWDk7waRQcQ5IhK9tHx6dZK2egfLV0aB7+N8stx5bUTTkf7FPlRagmFR LAhb9gbFmnhMknO2DUNRara2CE4CMJuTc2/k2nQRFtOC9LHk8cZamKsd/ImNqo5Gamjv 4kVqO6d/qHuSQEwFWVizum7obhC3RhH12vEIpYEsCMTIj21ho7lQwJMQLfNo/aDFe1vP 0RWcYxaIHcR/pqdkvyvmBb/3AW0ffOqSsaR5rDFBqRtQWZ21O41go37pSOHlD1QbiejZ XCciRtSg1+ny0k2Dtg1veOOLsogtsfEAB6wlWVGGSTsju0ceOu+0mc/+MNZGeUBWmlxv eTDA== X-Gm-Message-State: AOAM532K9xJKlxowYIY+C3nE1taV/jOCI27TG52KwCkk5v/XisBk86RK npMx/xbL7CdDqs4kyDNNyzYxeQZLLbtHTpyjQffbnvHjNhZi04IG X-Google-Smtp-Source: ABdhPJzT3166ftlSw7VS11FhzUJYsL6PkdxLLYQLf8UI3VmEFk6nR0bmWBkM/lpq6j4OxCiOBJ8FR3H9+zxaios0ByM= X-Received: by 2002:a2e:99cb:: with SMTP id l11mr1511555ljj.249.1605610450654; Tue, 17 Nov 2020 02:54:10 -0800 (PST) MIME-Version: 1.0 References: <20201115183609.3022395-1-aderumier@odiso.com> In-Reply-To: From: Alexandre Derumier Date: Tue, 17 Nov 2020 11:53:59 +0100 Message-ID: To: Thomas Lamprecht Cc: Proxmox VE development discussion , Stefan Reiter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.132 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH pve-kernel] add patch: vhost: bump max_mem_regions to 509 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 10:54:19 -0000 >>What is wrong with setting it as module option? Nothing wrong. in 2016, Dietmar wanted it in kernel. (don't remember, maybe the module option didn't exist at this time) >>above hunk for the submodule shouldn't be included in the patch, it refer= s to >>a git object which is not in ubuntus tree, probably only local in your wo= rking >>tree. oops, sorry. Do you prefer a module option file ? Le lun. 16 nov. 2020 =C3=A0 11:25, Thomas Lamprecht a =C3=A9crit : > > On 15.11.20 19:36, Alexandre Derumier wrote: > > Currently, default value is 64, so qemu is limited to 64 hotplug dimm > > > > original patch from 2015 > > https://patchwork.kernel.org/project/kvm/patch/1438180163-275465-3-git-= send-email-imammedo@redhat.com/ > > > > We have discusted about this in 2016 (At this time some optimisations p= atches were missing) > > https://lists.proxmox.com/pipermail/pve-devel/2016-December/024502.html > > > > What is wrong with setting it as module option? > https://lists.proxmox.com/pipermail/pve-devel/2016-December/024508.html > > > Also, this fix this bugzilla > > https://bugzilla.proxmox.com/show_bug.cgi?id=3D1426 > > > > Wolfgang proposed to have explicit dimm module management, it could be = great, > > but for now this patch is fixed the current implemlentation. > > > > > > maybe Stefan gets around to make this all a nicer approach? > > https://lists.proxmox.com/pipermail/pve-devel/2016-December/024519.html > > > > > Signed-off-by: Alexandre Derumier > > --- > > ...08-vhost-bump-max_mem_regions-to-509.patch | 32 +++++++++++++++++++ > > submodules/ubuntu-focal | 2 +- > > 2 files changed, 33 insertions(+), 1 deletion(-) > > create mode 100644 patches/kernel/0008-vhost-bump-max_mem_regions-to-5= 09.patch > snip > > diff --git a/submodules/ubuntu-focal b/submodules/ubuntu-focal > > index fd386a6..721ac24 160000 > > --- a/submodules/ubuntu-focal > > +++ b/submodules/ubuntu-focal > > @@ -1 +1 @@ > > -Subproject commit fd386a64a1ed3f2f047318508ebd733f56a4fab2 > > +Subproject commit 721ac248403a4c7ea98c416fc28f22c0bfbbb63d > > > > above hunk for the submodule shouldn't be included in the patch, it refer= s to > a git object which is not in ubuntus tree, probably only local in your wo= rking > tree. > >