From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4DC38719A5 for ; Thu, 9 Jun 2022 17:43:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3EFAF1EF77 for ; Thu, 9 Jun 2022 17:43:56 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EDA291EF66 for ; Thu, 9 Jun 2022 17:43:54 +0200 (CEST) Received: by mail-qk1-x72d.google.com with SMTP id b142so2430769qkg.2 for ; Thu, 09 Jun 2022 08:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowdernet.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=NsPNMOZn4mdBk5Nbw/csOByvewFykEtz8TvBjswl0fY=; b=iV3YhWkncEm5EgjE70/Da3gFcky9/1enNC2v5x28s+cr9EZ/pnGZHoE/HL+GAs1Jwj y+uUxx09O5OKF/i88sXYl7Wg81Z5r6pqnarBQiNTaF18XAm4P2vl4UW/e1jfT63ADFXx 7dT8nwk+KkBb42llj5eokwL+C2RTUsTcCtLn8ejspFVjNNttnmayp4dXgCt4fbFLoACV ua3lsO+gagiqOaOwp9rEfatTn30iBOU8r/tesFeRSkYvU7/GBqwC9IUCCwc8Q6dd6QRl NEdAiKHfv+SaegZUAQQyUs8BwscI8G9fPqTOxtChAo+nWMIFt22YJdmYKxEecAV6Ogp2 fKUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NsPNMOZn4mdBk5Nbw/csOByvewFykEtz8TvBjswl0fY=; b=R5VC/qPj8pa2/5LWOsRLer/2GE1dEP3Cyh1ZYAin0oBAB6fGVnuoeDGBAdknIi7DlA UIy7lfN7A64fIMKsxaARvD2Mv/9vKJ/WcrGxSMEH1vMvTj1L/RYcyFIljhNQqovrbHwN iBT2QbwHc6gT73PqyjLRKejTY9F2K+gbGyLZU90i9uhfQrxhbWsie1h8q+k9HU6REMDz NaFLXuBtEshqvayYCu88c4HK71GYIn8wZbFI3OzSuSTHfLQm6L0bMy59DSqS6+60DzPw 9FTM++fDar7DFUbRZFiWu0n+bvsklXS6F00uLjqQvWCTJycQEBn1q25QLSKLPTbcl1wg lnqg== X-Gm-Message-State: AOAM530IRReTzNyDQPasH/yuHzUXg4XgCumGtwhtDUygC5aAtswa9F8H N0yU30F6GFm2VWbino2/DxehCQDyVhkxVFS/ X-Google-Smtp-Source: ABdhPJwnLKR5SyJ8qtdk/AHO5BfrGF8Ki2ZEcbQAwkNM1G3j428RfU/jMN94eTm56KBT/Mzs8nXEnw== X-Received: by 2002:a05:620a:2484:b0:6a5:933c:a7f3 with SMTP id i4-20020a05620a248400b006a5933ca7f3mr27046642qkn.87.1654789427432; Thu, 09 Jun 2022 08:43:47 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id ay7-20020a05620a178700b006a73cb957dasm473097qkb.20.2022.06.09.08.43.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 08:43:47 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id x187so14875627ybe.2 for ; Thu, 09 Jun 2022 08:43:46 -0700 (PDT) X-Received: by 2002:a25:47c6:0:b0:65d:91bc:a149 with SMTP id u189-20020a2547c6000000b0065d91bca149mr38420186yba.14.1654789426673; Thu, 09 Jun 2022 08:43:46 -0700 (PDT) MIME-Version: 1.0 From: Daniel Bowder Date: Thu, 9 Jun 2022 08:43:21 -0700 X-Gmail-Original-Message-ID: Message-ID: To: pve-devel@lists.proxmox.com, Matthias Heiserer X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [bowdernet.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 15:43:56 -0000 > Is a string the best way of entering the CPUs in the GUI? Maybe a > dropdown where you can (un)select the cores? It would be a nice gui element to have a list of CPU cores with the ability to select individual ones. Such a feature would require the Options.js to know how many CPU cores the system had to dynamically generate the list I do not know how one would get that information to Options.js, but it certainly seems feasible. The cpuset list must be created eventually so that the cpuset can be used by taskset, so the underlying data structure remains this string. I do not yet have the required knowledge to add a dynamically generated list of CPU cores in the Options.js file. I do have the required knowledge to add this string formatted list. I would argue that having the feature in the GUI as a string is acceptable as a version 1 implementation. The string format does not lock us into anything and the gui can be upgraded to a fancy list in the future with no hindrances. The cpuset format in $vmid.conf is the way that this variable should be stored, so on the backend, there's nothing to change.