From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9177E91ACB for ; Fri, 30 Sep 2022 10:21:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 79B451B449 for ; Fri, 30 Sep 2022 10:21:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 30 Sep 2022 10:21:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B855445E3 for ; Fri, 30 Sep 2022 10:21:42 +0200 (CEST) Message-ID: <9ff40c74-480b-2bb3-02d3-f6549988ef26@proxmox.com> Date: Fri, 30 Sep 2022 10:21:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, Mira Limbeck References: <20220929133612.388969-1-m.limbeck@proxmox.com> <20220929133612.388969-2-m.limbeck@proxmox.com> From: Fiona Ebner In-Reply-To: <20220929133612.388969-2-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.099 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 2/2] reuse existing cloud-init disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2022 08:21:43 -0000 Am 29.09.22 um 15:36 schrieb Mira Limbeck: > When a disk exists but is not referenced in the config, it will be > reused instead of dying during the attempt to allocate the disk. > > Signed-off-by: Mira Limbeck > --- > This patch is not required to fix the rollback code, but might be nice > to have in addition since there will still be some users with cloud-init > disks left on the storage. > Nothing wrong with the patch AFAICT, just not fully convinced that it's worth the added complexity. The $create_disks sub is already a bit unwieldy unfortunately. So I'm fine with and without this patch :)