From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C0A681FF15C for ; Fri, 11 Jul 2025 09:42:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABE27A3C8; Fri, 11 Jul 2025 09:43:10 +0200 (CEST) Message-ID: <9fc1d8da-c35c-42fa-955d-514765cdf314@proxmox.com> Date: Fri, 11 Jul 2025 09:42:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Lukas Wagner , Proxmox VE development discussion References: <20250624112817.132312-1-l.wagner@proxmox.com> <20250624112817.132312-3-l.wagner@proxmox.com> From: =?UTF-8?Q?Michael_K=C3=B6ppl?= Content-Language: en-US In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 2/2] ui: backup job details: show notification-mode instead of legacy keys X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 7/9/25 10:18, Lukas Wagner wrote: > > Good point. For v3, I slightly shortened the strings to > > "Always send email" > "Send email on failure" > > Also, instead of rendering the recipient addresses in the same field by appending them to the string, > I created a second display field "Recipients", which is only visible if the legacy mode > will be used. If it is visible, but no mail address has been added > > "No recipients configured" > > is now shown. > > What do you think about this approach? > Just had a look at how you implemented this in v3 and I think that works a lot better. Thanks for adapting it! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel