From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 47E581FF139 for ; Tue, 24 Feb 2026 14:08:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4FAE3A75F; Tue, 24 Feb 2026 14:09:05 +0100 (CET) Message-ID: <9f908a5c-4040-41a6-8579-bb383f6b2325@proxmox.com> Date: Tue, 24 Feb 2026 14:09:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit] fix #7087: ui: enable direct task log download To: Proxmox VE development discussion , Dominik Rusovac References: <20251219144635.168818-1-d.rusovac@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20251219144635.168818-1-d.rusovac@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771938525344 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Y6267536AHYY5UL6QFO2MW4VQM22DDRO X-Message-ID-Hash: Y6267536AHYY5UL6QFO2MW4VQM22DDRO X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 19.12.25 um 3:47 PM schrieb Dominik Rusovac: > The web ui of both, PVE and PBS, now includes a "Download" button > allowing for a task log to be downloaded directly without opening the > task viewer pop-up. > > The enhancement originally related to PBS only, however this change > applies to PVE too and it seems more convenient to have it for both. > > Signed-off-by: Dominik Rusovac Reviewed-by: Fiona Ebner Tested-by: Fiona Ebner > --- > > Notes: > If desired, I could take on the implementation of download buttons for PDM. Yes, if we go for this feature, I think it makes sense to have it in PDM too :) > > src/node/Tasks.js | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/src/node/Tasks.js b/src/node/Tasks.js > index 661329a..002d909 100644 > --- a/src/node/Tasks.js > +++ b/src/node/Tasks.js > @@ -35,6 +35,21 @@ Ext.define('Proxmox.node.Tasks', { > }).show(); > }, > > + downloadTaskLog: function () { > + let me = this; > + let selection = me.getView().getSelection(); > + if (selection.length < 1) { > + return; > + } > + > + let rec = selection[0]; > + let task = Proxmox.Utils.parse_task_upid(rec.data.upid); > + > + Proxmox.Utils.downloadAsFile( > + `/api2/json/nodes/${task.node}/tasks/${encodeURIComponent(rec.data.upid)}/log?download=1`, Style nit: line too long, could be avoided by using a 'upid' variable, for example > + ); > + }, > + > updateLayout: function (store, records, success, operation) { > let me = this; > let view = me.getView().getView(); // the table view, not the whole grid > @@ -236,6 +251,13 @@ Ext.define('Proxmox.node.Tasks', { > disabled: true, > handler: 'showTaskLog', > }, > + { > + xtype: 'proxmoxButton', > + text: gettext('Download'), > + iconCls: 'fa fa-download', > + disabled: true, > + handler: 'downloadTaskLog', > + }, > { > xtype: 'button', > text: gettext('Reload'),